provide new generators: urandom and getentropy #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's the question how to annotate Fortuna to be racy. Should there be an |
Provide guidance to use these by default, document that Fortuna is not thread-safe. As suggested in mirage#249
hannesm
force-pushed
the
use-getrandom-into
branch
from
74690df to
f6bf346
Compare
reynir
reviewed
Nov 29, 2024
Co-authored-by: Reynir Björnsson <[email protected]>
Co-authored-by: Reynir Björnsson <[email protected]>
|
The failure semantics is now a bit sad: if for some reason the fd that has /dev/urandom open isn't able to read, we'll end up in an exception. previously with fortuna we were sure that once it is seeded, we'll never fail... but i guess if /dev/urandom doesn't deliver anymore we have other problems, and it's fine to raise an exception. |
since the pfortuna benchmark has been moved to bench/speed, remove bench/miou Mirage_crypto_rng_unix: remove getrandom_into
|
I think this is fine to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #249