-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template for multiple weights with diff between histogram with di… #354
Conversation
Thanks. One test failed: ============================= |
Template layout for tabsWe can make diff in respect to the varNorm - this is done per variable and we can compare different statistics with different weights Combinations:
Old templated had only normVar - [Yes, No] Test layout tabs
|
#Layout to test histoXYZWeight |
…ied syntax for using custom JS functions
…ons, will remove later
All tests are OKThere are many warnings - related to the unit test
After adding pytest.ini with unit test the amount was reduced to the 53
I will commit the pytest.ini after merging
|
I briefly reviewed the code and did not identify any obvious issues. We will need to develop a new unit test in which we prepare specialized data and define invariants to facilitate easier testing of self-consistency. I am merging the pull request, but the issue remains open for now. |
This PR:
-Fixes a major bug with generated javascript for using columns from different histograms/dataframes in one expression
-Fixes a bug with counting the length in joins on the client
-Adds a prototype implementation of #352