Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics not detected #18

Open
nohn opened this issue Jun 4, 2018 · 5 comments
Open

Google Analytics not detected #18

nohn opened this issue Jun 4, 2018 · 5 comments
Labels
duplicate This issue or pull request already exists

Comments

@nohn
Copy link

nohn commented Jun 4, 2018

Describe the bug
Google Analytics is not detected

To Reproduce
Steps to reproduce the behavior:

  1. gdpr scan https://www.ligatus.com/

Expected behavior
Google Analytics is detected

Desktop:

  • OS: Ubuntu 16.04 LTS
  • Node Version v10.3.0
  • Version 0.3.4

Additional context

ANALYTICS

No Analytics Tool has been found.

@DanielRuf
Copy link
Contributor

This is because it is in your head and not at the end of body like it should be in theory.

The inline JS parser just looks in the body.

@nohn
Copy link
Author

nohn commented Jun 4, 2018

Looking at chrome developer tools, it seems like the Google Analytics code works nevertheless. A tool designed for scanning code for whatever should also detect non-standard implementations of things.

@DanielRuf
Copy link
Contributor

DanielRuf commented Jun 4, 2018

Sure but this tool does not (yet) check global window variables or similar, just does a static analysis of the HTML, CSS and JS (so far).

For checking the real / live window, puppeteer or another solution is needed:
https://github.com/DanielRuf/website-stack/blob/master/index.js#L117

@mirkoschubert
Copy link
Owner

@DanielRuf That's not it. It's Issue #10. The HTML head is parsed as well.
@nohn The problem is, that the website uses the legacy ga.js code snippet, which ist deprecated and shouldn't been used anymore. 😏 Version 0.3.4 doesn't support this legacy snippet. But I already fixed it. It works fine in the dev branch and will be publicly available in the next version. In your case it outputs:

ANALYTICS

Google Analytics has been found.

Property ID:        UA-27699003-1
Anonymized IP:      No
Force SSL:          No

Warning! www.ligatus.com uses the legacy ga.js code snippet (deprecated).

@mirkoschubert mirkoschubert added the duplicate This issue or pull request already exists label Jun 4, 2018
@mirkoschubert
Copy link
Owner

Btw. reminder to myself: I have to check »anonymizeIP« for the legacy snippet as well. I didn't know it was even possible 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants