Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tries to open a file in web browser when click on the seen status #247

Open
swodig112 opened this issue Aug 15, 2021 · 2 comments · May be fixed by #254
Open

Tries to open a file in web browser when click on the seen status #247

swodig112 opened this issue Aug 15, 2021 · 2 comments · May be fixed by #254
Labels
bug Something isn't working

Comments

@swodig112
Copy link

Description

When I click on the seen status (the blue circle and the number next to it which indicates how many people have seen a message) mirage opens "qrc:/src/gui/Base/HSelectableLabel.qml#state-text" in firefox (my default web browser) and searches it using the default search engine. I guess a string is mishandled somewhere.

Your environment

Steps to reproduce

  1. Open a chat.
  2. Click on the seen status in the bottom of a message.

Expected behavior

Nothing although it should show who has seen the message when you hover on it.

Actual behavior

It shows who has seen the message but also opens "qrc:/src/gui/Base/HSelectableLabel.qml#state-text" in firefox.
@swodig112 swodig112 added the bug Something isn't working label Aug 15, 2021
@MRAAGH
Copy link
Contributor

MRAAGH commented Aug 15, 2021

I have the same issue. I suspect xdg-open qrc:/src/gui/Base/HSelectableLabel.qml#state-text was executed.

@MRAAGH
Copy link
Contributor

MRAAGH commented Aug 30, 2021

This happens because the indicator is a link (that's how we can get a hover text).
Funnily enough, if you put [test](#state-text) in an actual message, this link will become a read indicator too!
I will try to add an exception in the link handler to fix this.

MRAAGH added a commit to MRAAGH/mirage that referenced this issue Aug 30, 2021
@MRAAGH
Disable seen indicator link
180c02d 
The seen indicator is a link to #state-text.
This link should not be clickable.
Fixes mirukana#247
@MRAAGH MRAAGH linked a pull request Aug 30, 2021 that will close this issue
Open
@MRAAGH MRAAGH mentioned this issue Jan 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable seen indicator link MRAAGH/mirage
2 participants
@MRAAGH @swodig112