From 1f7c8659f6c8d0630e69d6c384cf7faa6a25334d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Klitzing?= Date: Tue, 9 Jul 2024 00:02:08 +0200 Subject: [PATCH] Fix skip with topics --- contrib/mercurial_git_push.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/contrib/mercurial_git_push.py b/contrib/mercurial_git_push.py index 08f5363..fbf745a 100755 --- a/contrib/mercurial_git_push.py +++ b/contrib/mercurial_git_push.py @@ -445,17 +445,18 @@ def summary(self): def skippable(self): if self._skippable is None: + self._skippable = False regex = r'Reviewed at https://' for changeset in self._changesets: if changeset.summary().startswith('SKIP'): self._skippable = True self._failure = 'Starts with SKIP' + break elif re.search(regex, changeset.desc()): self._skippable = True self._failure = 'Description contains: "%s"' % regex - else: - self._skippable = False + break return self._skippable