Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): 起動前の疎通チェックが機能しなくなっていた問題を修正 #15043

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

What

allSettled does not throw if a promise is rejected, so check_connect never actually failed

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

dakkar and others added 2 commits November 23, 2024 15:15
`allSettled` does not throw if a promise is rejected, so
`check_connect` never actually failed
@kakkokari-gtyih kakkokari-gtyih added this to the v2024.11.1? milestone Nov 23, 2024
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 23, 2024
Copy link
Contributor

github-actions bot commented Nov 23, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.97%. Comparing base (a77ad7a) to head (60614a1).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15043      +/-   ##
===========================================
+ Coverage    39.96%   39.97%   +0.01%     
===========================================
  Files         1563     1563              
  Lines       197744   197744              
  Branches      3631     3647      +16     
===========================================
+ Hits         79027    79056      +29     
+ Misses      118112   118083      -29     
  Partials       605      605              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants