Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Crafting Checks and Process #122

Open
misterpotts opened this issue Mar 23, 2023 · 0 comments
Open

Feature: Crafting Checks and Process #122

misterpotts opened this issue Mar 23, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@misterpotts
Copy link
Owner

misterpotts commented Mar 23, 2023

Description

Salvaging components and crafting recipes may be instantaneous, or require several stages to complete. For both types of crafting attempt, they may be successful, or unsuccessful.

I'm opinionated about whether a crafting system should allow different types of checks per recipe. When I look at crafting systems published by Wizards of the Coast and 3rd party publishers for 5th Edition, as well as game systems such as Pathfinder 2nd Edition, all popular crafting systems have a consistent crafting process, difficulty class calculation, and set of checks across all of their recipes.

This makes sense to me; crafting process variability by recipe is an unnecessary level of complexity for a crafting system. It doesn't appeal to players and it isn't worth solving for me. Fabricate will therefore not support this directly. I.e. there will only be one crafting check and one salvage check per crafting system. If you want variability you can still achieve this with Fabricate, but you will have to take on the additional effort of creating an additional crafting system, or writing custom check macros that handle this.

Benefit(s)

  • Checks are a major feature required for submission to the official module list
  • Checks have been a much requested feature

Potential Implementation(s)

The crafting process can be used to represent each kind of crafting, from salvaging to recipe crafting. It might look something like this.

classDiagram
class CraftingProcess
<<interface>> CraftingProcess
CraftingProcess : +number steps
CraftingProcess : +number progress
CraftingProcess : Check[] checksPerformed
CraftingProcess: +boolean isCheckRequired
CraftingProcess: +boolean isComplete
Loading

Additional Context

Relates to #88

@misterpotts misterpotts added enhancement New feature or request triage The Issue is not yet ready to work labels Mar 23, 2023
@misterpotts misterpotts removed the triage The Issue is not yet ready to work label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant