Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You can have multiple TCP connections to a peer and still have it be listed as the same peerIdx despite there being multiple "Peer" objects #410

Open
delbonis opened this issue Oct 12, 2018 · 3 comments
Open

You can have multiple TCP connections to a peer and still have it be listed as the same peerIdx despite there being multiple "Peer" objects #410

delbonis opened this issue Oct 12, 2018 · 3 comments
Assignees
@delbonis
Labels
bug Actual problems effecting Lit's usage/performance

Comments

@delbonis
Copy link
Collaborator

Everything still works fine but it probably would lead to problems at a later date. This should be fixed in lnp2p, returning an error if you're already connected.
@delbonis delbonis self-assigned this Oct 12, 2018
@delbonis delbonis added the bug Actual problems effecting Lit's usage/performance label Oct 12, 2018
@Varunram
Copy link
Contributor

lnp2p is broken in multiple places at the moment (many of which we can't seem to identify). We should fix that first and then proceed to build on top of it.

@delbonis
Copy link
Collaborator Author

Other than this and the PR I already submitted it'd be good if we could make a list of the other problems it has.

@delbonis
Copy link
Collaborator Author

Most of the work is on #411.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delbonis delbonis

Labels
bug Actual problems effecting Lit's usage/performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Varunram @delbonis