-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels of values in menus #17
Comments
Hey @jamiefolsom ! Did you took the time to check if you could fix those? Thanks for the follow up! |
Hi @blirette , yes, I feel confident that these are issues I can address. These are values in the database, so I can make the changes there directly. I think I can do that this week, and I will keep you posted. Thanks! |
@blirette I've updated this issue with latest progress -- see https://performant-software.github.io/analytics/ |
Thanks! Do you think you'll have the time to clear them all by Friday? |
Hi @blirette -- I've set aside a number of hours tomorrow for this work, so I should be able to make good progress on it. I will keep you posted as I go. |
Hi @blirette, I've been busy today integrating the crosstab browser into the new website design: http://staging.cfregisters.org/app, which is almost complete. I have some hours left in the budget for the remainder of this issue (#17), so I will resume work on it on Monday. Thanks. |
Hey @jamiefolsom, Are all the issues listed here done? Are they online on http://cfrp-laval.github.io/analytics/? Thanks for the update! |
Hi @blirette, The completed items, as reflected on the checkboxes above, are visible at: https://performant-software.github.io/analytics/ I am working on the ones not yet completed this week, and I will deploy them to that copy of the site; if you agree those changes look good, I will deploy them to the live site. A question for you -- is anyone else working on the site? I want to avoid my work conflicting with others'. Thanks! Jamie |
I don't know of anyone working of the website part of the tool. I doubt @hspier has that access. |
OK and is @hspier working on this repo at the moment (https://github.com/cfrp-laval/analytics/)? Thanks. |
He's probably using that one. I'll let him confirm that. |
OK, thanks. |
@blirette am I correct that under "Auteur", you would like the first label within the section to be modified, as seen here? Or is it that you'd like the top-level label to be modified (one step higher)? Thanks. |
@blirette, under Genre, there is a play in the database for which the genre is '0'. What should that be, or should it be excluded?
|
@blirette likewise, there are 117 plays for which the value of |
I have located the source of the |
@jamiefolsom` and @blirette, there are 5 verification states:
The warehouse load script respects the verification flag: it ignores 'pas verifie', 'pas saisie', and 'archive' entries and loads 'verifie' and 'probleme' ones. (I was told the data entry team uses the latter to mean 'marked for use, but still has problems', with discards going into 'archive'). It might be worth confirming with Sara whether the DE team have maintained this policy. Here are the relevant lines in the load script, if you want to revise which tags mark registers that go into the warehouse: https://github.com/mit-history/cfrp/blob/5047816bb7c9b028356d2c583b73125c5dbe2e44/lib/tasks/warehouse.rake#L47 |
Hi @christopheryork, Actually, I was referring to a flag on the plays table, which allows marking plays as "expert validated", which at one point, it appears that the warehouse load script did take into account, but now that WHERE clause is commented out. Which I think could be leading to duplicate plays being included. Does that make sense? Thanks! |
Right - I see the flag in question now. Since the star schema is only queried after some dimension tables (e.g. plays_dim) are joined to the fact table (sales_facts), it should be okay as is. Only plays that are actually used in a register entry marked "verifie" or "probleme" will be included in analytics. Best -- C |
@jamiefolsom top-level label "Auteur" is correct. You don't have to change it. Anyway, thanks! |
@jamiefolsom Could you send me the list of the 117 plays? Text or CSV or any format will do. Sara wants to look at those. Thanks! |
Hi @blirette, Here's the list. Also attached as a text file. [UPDATED]: I've sorted the plays_without_acts by title. Thanks, Jamie
|
Hi @blirette, For comparison's sake, here's the list of plays with a non-null value for acts (there are 1067 of them). Thanks, Jamie |
Thanks @jamiefolsom ! I've sent it to Sara. |
Hi @christopheryork, Circling back on the question of So I'm working on a staging copy of the database, which is complete, and recent, so I think this a good test. Assuming that
Obviously, it's good that there's a foreign key constraint on these records, but it would seem to indicate that there are [Update] See: mit-history/cfrp#3 Thanks! |
Hi @blirette, I believe I've narrowed down the issue with the
Note that there are three plays here which are expert validated, but which don't have act values, and there is one which is not expert validated, which also has no data in the record. All registers which point to these plays should be "remapped" to play records which are valid, and have act values. Shall I request that help from Sara or would you like to? Thanks! |
In other words, Sara would need to insert the correct data for the plays' id 856 and fill the acts of all the other ids above? |
Correct -- I've emailed Sara about this. |
@jamiefolsom Did you get the answer needed from Sara do resolve this issue? Thanks for the update! |
@blirette I think so. I will keep you posted. |
@jamiefolsom Got any updates on that? Thanks! |
@jamiefolsom Did you find a solution to this? Thanks for the update! |
Hi,
We need to verify some labels of values displayed in the different submenus. Here's the list of changes, translations and questions.
Jamie, I think you should be able to do those while Hugo is away. Can you confirm that to me? Thanks!
In «Pièce» section:
In «Auteur» section:
In «Genre» section:
In «Places» section:
In «Actes» section:
The text was updated successfully, but these errors were encountered: