Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels of values in menus #17

Open
16 of 21 tasks
blirette opened this issue Dec 14, 2016 · 33 comments
Open
16 of 21 tasks

Labels of values in menus #17

blirette opened this issue Dec 14, 2016 · 33 comments
Assignees

Comments

@blirette
Copy link

blirette commented Dec 14, 2016

Hi,

We need to verify some labels of values displayed in the different submenus. Here's the list of changes, translations and questions.

Jamie, I think you should be able to do those while Hugo is away. Can you confirm that to me? Thanks!

  • After clicking «Nouvelle Recherche», the label displays «Somme recette (pondérée)». Remove the part that says «(pondérée)».

In «Pièce» section:

  • In «Pièce»: First value without a label.
  • In «Seconde pièce»: First value without a label.
  • In «Troisième pièce»: First value without a label.

In «Auteur» section:

  • First value without a label.
  • Add «(pièces 1, 2 et 3)» to better define the section's label (Auteur (pièces 1, 2 et 3)).
  • In «Auteur de la seconde pièce» section: First value without a label.
  • In «Auteur de la troisième pièce» section: First value without a label.

In «Genre» section:

  • 2 entries without a proper label.
  • Add «(pièces 1, 2 et 3)» to better define the section's label (Genre (pièces 1, 2 et 3)).
  • In «Genre de la seconde pièce» section: 2 entries without a proper label.
  • In «Genre de la troisième pièce» section: 1 entry without a proper label.

In «Places» section:

  • Change «All others» for «Autres places non spécifiées»
  • Change «Balconies» for «Balcons»
  • Change «Premières loges and stage seating» for «Premières loges et places sur le théâtre»
  • Change all «&» for «et»

In «Actes» section:

  • In the section «Acte(s)n»: You have values without labels as choices (before «1» and after «6»).
  • In the section «Acte(s)1»»: You have a value without a label (after «6»).
  • In the section «Acte(s)2»: You have values without labels as choices (before «1» and after «5»).
  • In the section «Acte(s)3»: You have a value without a label as choice (after «5»).
  • Is it normal that there is no value «4»?
@blirette
Copy link
Author

Hey @jamiefolsom ! Did you took the time to check if you could fix those? Thanks for the follow up!

@jamiefolsom
Copy link
Member

Hi @blirette , yes, I feel confident that these are issues I can address. These are values in the database, so I can make the changes there directly. I think I can do that this week, and I will keep you posted. Thanks!

@jamiefolsom
Copy link
Member

@blirette I've updated this issue with latest progress -- see https://performant-software.github.io/analytics/

@blirette
Copy link
Author

Thanks! Do you think you'll have the time to clear them all by Friday?

@jamiefolsom
Copy link
Member

Hi @blirette -- I've set aside a number of hours tomorrow for this work, so I should be able to make good progress on it. I will keep you posted as I go.

@jamiefolsom
Copy link
Member

Hi @blirette, I've been busy today integrating the crosstab browser into the new website design: http://staging.cfregisters.org/app, which is almost complete. I have some hours left in the budget for the remainder of this issue (#17), so I will resume work on it on Monday. Thanks.

@blirette
Copy link
Author

Hey @jamiefolsom,

Are all the issues listed here done? Are they online on http://cfrp-laval.github.io/analytics/?

Thanks for the update!

@jamiefolsom
Copy link
Member

Hi @blirette,

The completed items, as reflected on the checkboxes above, are visible at: https://performant-software.github.io/analytics/

I am working on the ones not yet completed this week, and I will deploy them to that copy of the site; if you agree those changes look good, I will deploy them to the live site.

A question for you -- is anyone else working on the site? I want to avoid my work conflicting with others'.

Thanks!

Jamie

@blirette
Copy link
Author

I don't know of anyone working of the website part of the tool. I doubt @hspier has that access.

@jamiefolsom
Copy link
Member

OK and is @hspier working on this repo at the moment (https://github.com/cfrp-laval/analytics/)? Thanks.

@blirette
Copy link
Author

He's probably using that one. I'll let him confirm that.

@jamiefolsom
Copy link
Member

OK, thanks.

@jamiefolsom
Copy link
Member

@blirette am I correct that under "Auteur", you would like the first label within the section to be modified, as seen here?

screen shot 2017-01-23 at 4 28 54 pm

Or is it that you'd like the top-level label to be modified (one step higher)? Thanks.

@jamiefolsom
Copy link
Member

Deuxième option:

screen shot 2017-01-23 at 4 31 23 pm

@jamiefolsom
Copy link
Member

@blirette, under Genre, there is a play in the database for which the genre is '0'. What should that be, or should it be excluded?

cfrp-staging::DATABASE=> select id, author, title, genre, acts from play_dim where genre = '0';
  id  | author  |      title       | genre | acts
------+---------+------------------+-------+------
 5700 | Anonyme | Le Laquais fille | 0     |    0

@jamiefolsom
Copy link
Member

@blirette likewise, there are 117 plays for which the value of acts is NULL. I believe those should be excluded, but please confirm. NOTE: I believe this is because the data warehouse ignores our "expert validated" flag, which permitted Sara to mark some plays as superfluous. I will confirm, but if you speak with her, that would be good to mention, so she doesn't worry that her clean data have been corrupted. Once these questions are resolved, I can correct the remaining issues and deploy to staging, then to production. Thanks!

@jamiefolsom
Copy link
Member

I have located the source of the & characters in the names of places. I've made the change in the staging database, and will do the same in the production db when the time is right.

@forestofarden
Copy link
Collaborator

forestofarden commented Jan 24, 2017

@jamiefolsom` and @blirette, there are 5 verification states:

cfrp_development=# select * from verification_states order by id;
 id |    name     | description 
----+-------------+-------------
  1 | verifie     | 
  2 | pas verifie | 
  5 | pas saisie  | 
  6 | probleme    | 
  7 | archive     | 
(5 rows)

The warehouse load script respects the verification flag: it ignores 'pas verifie', 'pas saisie', and 'archive' entries and loads 'verifie' and 'probleme' ones. (I was told the data entry team uses the latter to mean 'marked for use, but still has problems', with discards going into 'archive').

It might be worth confirming with Sara whether the DE team have maintained this policy. Here are the relevant lines in the load script, if you want to revise which tags mark registers that go into the warehouse:

https://github.com/mit-history/cfrp/blob/5047816bb7c9b028356d2c583b73125c5dbe2e44/lib/tasks/warehouse.rake#L47
https://github.com/mit-history/cfrp/blob/5047816bb7c9b028356d2c583b73125c5dbe2e44/lib/tasks/warehouse.rake#L86

@jamiefolsom
Copy link
Member

Hi @christopheryork,

Actually, I was referring to a flag on the plays table, which allows marking plays as "expert validated", which at one point, it appears that the warehouse load script did take into account, but now that WHERE clause is commented out.

https://github.com/mit-history/cfrp/blob/5047816bb7c9b028356d2c583b73125c5dbe2e44/lib/tasks/warehouse.rake#L62

Which I think could be leading to duplicate plays being included. Does that make sense?

Thanks!

@forestofarden
Copy link
Collaborator

Right - I see the flag in question now. Since the star schema is only queried after some dimension tables (e.g. plays_dim) are joined to the fact table (sales_facts), it should be okay as is. Only plays that are actually used in a register entry marked "verifie" or "probleme" will be included in analytics. Best -- C

@blirette
Copy link
Author

@jamiefolsom top-level label "Auteur" is correct. You don't have to change it.
For the "Genre" question and the verification states, I wrote an email to Sara. Will get back to you on that. Personally, I find that weird that they are loading the "problem" ones...

Anyway, thanks!

@blirette
Copy link
Author

@jamiefolsom Could you send me the list of the 117 plays? Text or CSV or any format will do. Sara wants to look at those. Thanks!

@jamiefolsom
Copy link
Member

jamiefolsom commented Jan 24, 2017

Hi @blirette,

Here's the list. Also attached as a text file.

[UPDATED]: I've sorted the plays_without_acts by title.

Thanks,

Jamie

  id  | acts | expert_validated |                       title                        |                                             author                                              |       genre
------+------+------------------+----------------------------------------------------+-------------------------------------------------------------------------------------------------+--------------------
  935 |      |                  |                                                    | Jean-François Cailhava d’Estendoux                                                              |
  476 |      |                  |                                                    | Sauvigny                                                                                        | tragedie
  856 |      |                  |                                                    |                                                                                                 |
 5247 |      | f                |                                                    |                                                                                                 |
 1368 |      |                  |                                                    | M. Duis                                                                                         |
 3611 |      |                  | ??                                                 |                                                                                                 |
 4511 |      |                  | ??                                                 |                                                                                                 |
 1577 |      |                  | Agis                                               |                                                                                                 |
 3585 |      |                  | Au Proffit?                                        |                                                                                                 |
 3557 |      |                  | Au Proffit?                                        |                                                                                                 |
 3571 |      |                  | Au Proffit?                                        |                                                                                                 |
 3537 |      |                  | Au Proffit?                                        |                                                                                                 |
 3588 |      |                  | Chazette?                                          |                                                                                                 |
 3542 |      |                  | Chazette?                                          |                                                                                                 |
 3560 |      |                  | Chazette?                                          |                                                                                                 |
 3574 |      |                  | Chazette?                                          |                                                                                                 |
 4827 |      |                  | Crispin brulé                                      |                                                                                                 |
 4445 |      |                  | Crispin brulé                                      |                                                                                                 |
 4498 |      |                  | crispin brûlé?                                     |                                                                                                 |
 5917 |      | t                | Danse de Gigogne                                   | Anonyme                                                                                         | divertissement
 4397 |      |                  | Democrite à la cour                                |                                                                                                 |
 4489 |      |                  | Dezede?                                            |                                                                                                 |
   20 |      |                  | Dom Juan ou Le Festin de Pierre                    | Jean-Baptiste Poquelin dit Molière                                                              | comédie
 4136 |      |                  | famlle                                             |                                                                                                 |
 1374 |      |                  | Feythere                                           | Voltaire                                                                                        | tragedie
 1352 |      |                  | Gaston et Bayard                                   |                                                                                                 |
 4416 |      |                  | Intermedes                                         |                                                                                                 |
 4241 |      |                  | Intermedes?                                        |                                                                                                 |
 4427 |      |                  | Intermèdes                                         |                                                                                                 |
 1617 |      |                  | La [...] campagne                                  |                                                                                                 |
 1248 |      |                  | La [...] campagne                                  |                                                                                                 |
 1348 |      |                  | La Comtesse d'Escarbagnas                          |                                                                                                 |
 1461 |      |                  | La Coquette                                        |                                                                                                 |
 1217 |      |                  | La Coquette                                        |                                                                                                 |
 1612 |      |                  | La Coquette                                        |                                                                                                 |
 1586 |      |                  | La Coquette                                        |                                                                                                 |
 1243 |      |                  | La Coquette                                        |                                                                                                 |
 1059 |      |                  | La Coquette                                        |                                                                                                 |
 4328 |      |                  | La Fausse [...]                                    |                                                                                                 |
 3612 |      |                  | La Philosophie                                     | M. Alexandre-Louis-Bertrand Robineau dit Beaunoir                                               | drame
  215 |      |                  | La Reprise de Toulon ou Les Patriotes provinciaux  | André Pépin Bellement                                                                           |
 1715 |      |                  | Le Bienfait anonyme ou le faux généreux            | M. Alexandre-Guillaume Moulier de Moissy                                                        | comédie
 1343 |      | f                | Le Cercle ou la Soirée à la mode                   |                                                                                                 |
 1574 |      |                  | Le [...] de campagne                               |                                                                                                 |
 1205 |      |                  | Le [...] de campagne                               |                                                                                                 |
 5677 |      | t                | Le Désespoir extravagant                           | Subligny (Adrien-Thomas Perdou de)                                                              | comédie
  931 |      |                  | Le Glorieux                                        | Marc-Antoine Legrand / Le Grand                                                                 | comédie
  938 |      |                  | Legre                                              |                                                                                                 |
 4529 |      |                  | Le Jaloux                                          |                                                                                                 |
 4533 |      |                  | Le Jaloux                                          |                                                                                                 |
 4539 |      |                  | Le Jaloux                                          |                                                                                                 |
 4717 |      |                  | Le Jaloux                                          |                                                                                                 |
 5154 |      |                  | Le Médecin de l'amour                              | Anseaume (Louis) ; Marcouville (Pierre-Augustin Lefèvre de Marcouville dit)                     | musique
 4514 |      |                  | Les Agrements???                                   |                                                                                                 |
 4400 |      |                  | Les Agrements???                                   |                                                                                                 |
  267 |      |                  | Les Amants brouillés par Arlequin messager balourd | Michel Procope-Couteaux                                                                         | comédie
 1022 |      |                  | Les Amants brouillés par Arlequin messager balourd | Michel Procope-Couteaux                                                                         | comédie
 4463 |      |                  | Les [...] de Crispin                               |                                                                                                 |
 4804 |      |                  | Les Épreuves                                       |                                                                                                 |
 4780 |      |                  | Les Hommes du jour                                 | M. Henri-Alex. Allaire                                                                          | vaudeville
 1714 |      |                  | Les Horaces                                        | M. François-Guillaume Ducray-Duminil                                                            | tragédie
  930 |      |                  | Le Siège de Calais                                 | Florent Carton dit Dancourt                                                                     | comédie
 4426 |      |                  | Les Intermèdes                                     |                                                                                                 |
 1591 |      |                  | Les Journalistes                                   |                                                                                                 |
 1222 |      |                  | Les Journalistes                                   |                                                                                                 |
 1589 |      |                  | Les Journalistes Anglois                           |                                                                                                 |
 1220 |      |                  | Les Journalistes Anglois                           |                                                                                                 |
 1219 |      |                  | Les Journalistes Anglois                           |                                                                                                 |
 1600 |      |                  | Les Journalistes Anglois                           |                                                                                                 |
 1587 |      |                  | Les Journalistes Anglois                           |                                                                                                 |
 1225 |      |                  | Les Journalistes Anglois                           |                                                                                                 |
 1594 |      |                  | Les Journalistes Anglois                           |                                                                                                 |
 1231 |      |                  | Les Journalistes Anglois                           |                                                                                                 |
 1588 |      |                  | Les Journalistes Anglois                           |                                                                                                 |
 4303 |      |                  | Les Meprises                                       |                                                                                                 |
 4304 |      |                  | Les Meprises                                       |                                                                                                 |
  159 |      |                  | Les Noms changés ou l'Indifférent corrigé          | Pierre Nicolas Brunet Debaines                                                                  | comédie
 4167 |      |                  | Les physiciennes?                                  |                                                                                                 |
  706 |      |                  | Les Poupées                                        | Marc-Antoine Legrand / Le Grand                                                                 | comédie
 4418 |      |                  | Les Rivaux amis                                    | Abbé François Le Métel de Boisrobert                                                            | tragi comédie
  751 |      |                  | Les Soubrettes                                     | Laujon                                                                                          | comédie en 5 actes
  752 |      |                  | Les Soubrettes                                     | Laujon                                                                                          | comédie en 5 actes
  753 |      |                  | Les Soubrettes                                     | Laujon                                                                                          | comédie en 5 actes
 1177 |      |                  | Les Trois tuteurs                                  |                                                                                                 |
 1548 |      |                  | Les Trois tuteurs                                  |                                                                                                 |
 1544 |      |                  | Les Trois tuteurs                                  |                                                                                                 |
 1179 |      |                  | Les Trois tuteurs                                  |                                                                                                 |
 1546 |      |                  | Les Trois tuteurs                                  |                                                                                                 |
 1175 |      |                  | Les Trois tuteurs                                  |                                                                                                 |
 4179 |      |                  | Les Trois tuteurs                                  |                                                                                                 |
 4186 |      |                  | Les Trois tuteurs                                  |                                                                                                 |
 4196 |      |                  | Les Trois tuteurs                                  |                                                                                                 |
 4504 |      |                  | Les Vacances des procureurs                        | Sieur Florent Carton dit Dancourt                                                               | comédie
   60 |      | f                | L'Ile déserte                                      | Jean-Baptiste Collet de Messine                                                                 | comédie
 4393 |      |                  | L’Oestre                                           |                                                                                                 |
 1711 |      |                  | Marius ou Marius à Cyrthe                          | Sieur Gilles de Caux de Montlebert et M. Charles-Jean-François Hénault dit le Président Hénault | tragédie
 1169 |      |                  | Molière à la nouvelle salle                        |                                                                                                 |
 1170 |      |                  | Molière à la nouvelle salle                        |                                                                                                 |
 4133 |      |                  | nouvea#                                            |                                                                                                 |
 4312 |      |                  | Philoctete                                         |                                                                                                 |
 4555 |      |                  | Philoctete                                         |                                                                                                 |
 4568 |      |                  | Philoctete                                         |                                                                                                 |
 4273 |      |                  | Philoctete                                         |                                                                                                 |
 4332 |      |                  | Philoctete                                         |                                                                                                 |
 4324 |      |                  | Philoctete                                         |                                                                                                 |
 4277 |      |                  | Philoctete                                         |                                                                                                 |
 4414 |      |                  | Philoctète                                         |                                                                                                 |
 4465 |      |                  | Philoctète                                         |                                                                                                 |
 4468 |      |                  | Philoctète                                         |                                                                                                 |
 4475 |      |                  | Philoctète                                         |                                                                                                 |
  186 |      |                  | Sophonisbe                                         | François-Marie Arouet dit Voltaire                                                              | tragédie
 5878 |      | t                | Suivante généreuse (La)                            | Sablier (Charles)                                                                               | comédie
  933 |      |                  | Turcaret                                           | Jean Racine                                                                                     | tragédie
  221 |      |                  | unidentified                                       | unidentified                                                                                    | unidentified
 4323 |      |                  | [...] Verneuil                                     |                                                                                                 |
 1139 |      |                  | Zélémide                                           | Abbé Claude-Henri de Fusée de Voisenon                                                          |
  216 |      |                  | Zélémide                                           | Abbé Claude-Henri de Fusée de Voisenon                                                          |
(117 rows)

plays_without_acts.txt

@jamiefolsom
Copy link
Member

Hi @blirette,

For comparison's sake, here's the list of plays with a non-null value for acts (there are 1067 of them).

plays_with_acts.txt

Thanks,

Jamie

@blirette
Copy link
Author

Thanks @jamiefolsom ! I've sent it to Sara.

@jamiefolsom
Copy link
Member

jamiefolsom commented Jan 25, 2017

Hi @christopheryork,

Circling back on the question of plays with no acts value.

So I'm working on a staging copy of the database, which is complete, and recent, so I think this a good test. Assuming that play_dim is both rebuilt from the normalized tables daily, and that that's where the data come from for the analytics app, I tried deleting the plays which have NULL values in the acts column, since that's what would be producing the filter checkboxes with no label, and got the following:

cfrp-staging::DATABASE=> delete from play_dim where acts is NULL; -- just a test; I know this would be rebuilt from public.plays
ERROR:  update or delete on table "play_dim" violates foreign key constraint "sales_facts_play_2_id_fkey" on table "sales_facts"
DETAIL:  Key (id)=(856) is still referenced from table "sales_facts".

Obviously, it's good that there's a foreign key constraint on these records, but it would seem to indicate that there are sales_facts which depend on these "obsolete" play records. So I am thinking we might try reinstating the WHERE expert_validated clause in the warehouse script, to exclude those plays which... aren't. I would welcome your thoughts on this of course.

[Update] See: mit-history/cfrp#3

Thanks!

@jamiefolsom
Copy link
Member

Hi @blirette,

I believe I've narrowed down the issue with the acts filter menu somewhat, with @christopheryork's help. It appears that there are some registers in the database which are still referring to some plays which are not meant to be used.

  id   |    date    | ordering | acts | expert_validated | play_id |        play_title
-------+------------+----------+------+------------------+---------+--------------------------
 24629 | 1684-11-23 |        2 |      | t                |    5917 | Danse de Gigogne
 24654 | 1684-12-19 |        2 |      | t                |    5917 | Danse de Gigogne
 34950 | 1688-10-27 |        2 |      | t                |    5677 | Le Désespoir extravagant
 17370 | 1746-04-24 |        3 |      |                  |     856 |
 17377 | 1746-05-01 |        3 |      |                  |     856 |
 21142 | 1759-05-23 |        1 |      | t                |    5878 | Suivante généreuse (La)
 21144 | 1759-05-26 |        1 |      | t                |    5878 | Suivante généreuse (La)
  3289 | 1770-02-19 |        2 |      |                  |     856 |
  3295 | 1770-02-25 |        2 |      |                  |     856 |
  3407 | 1770-07-25 |        2 |      |                  |     856 |
  3526 | 1770-12-02 |        2 |      |                  |     856 |
  3551 | 1770-12-30 |        2 |      |                  |     856 |
  4172 | 1773-01-23 |        2 |      |                  |     856 |
  2954 | 1774-02-10 |        2 |      |                  |     856 |
  2957 | 1774-02-13 |        2 |      |                  |     856 |
  2959 | 1774-02-15 |        2 |      |                  |     856 |
  2964 | 1774-02-20 |        2 |      |                  |     856 |
  2967 | 1774-02-23 |        2 |      |                  |     856 |
  2971 | 1774-02-27 |        2 |      |                  |     856 |
  2983 | 1774-03-13 |        2 |      |                  |     856 |
(20 rows)

cfrp-staging::DATABASE=> select * from plays where id = 856;
 id  | author | title | genre | created_at | updated_at | acts | prose_vers | prologue | musique_danse_machine | alternative_title | url | date_de_creation | expert_validated | _packed_id
-----+--------+-------+-------+------------+------------+------+------------+----------+-----------------------+-------------------+-----+------------------+------------------+------------
 856 |        |       |       |            |            |      |            |          |                       |                   |     |                  |                  |        122
(1 row)

Note that there are three plays here which are expert validated, but which don't have act values, and there is one which is not expert validated, which also has no data in the record. All registers which point to these plays should be "remapped" to play records which are valid, and have act values. Shall I request that help from Sara or would you like to? Thanks!

@blirette
Copy link
Author

In other words, Sara would need to insert the correct data for the plays' id 856 and fill the acts of all the other ids above?

@jamiefolsom
Copy link
Member

jamiefolsom commented Jan 26, 2017

Correct -- I've emailed Sara about this.

@blirette
Copy link
Author

@jamiefolsom Did you get the answer needed from Sara do resolve this issue? Thanks for the update!

@jamiefolsom
Copy link
Member

@blirette I think so. I will keep you posted.

@blirette
Copy link
Author

@jamiefolsom Got any updates on that? Thanks!

@blirette
Copy link
Author

@jamiefolsom Did you find a solution to this? Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants