Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_package glfw when NANOGUI_BUILD_GLFW=OFF #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Jan 19, 2022

  1. find_package glfw when NANOGUI_BUILD_GLFW=OFF

    Also include some missing CMake utilities for install logic.
    svenevs committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    19cac59 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. [squash this] include(GNUInstallDirs) sooner for $<INSTALL_INTERFACE>…

    … defs.
    
    Not sure how I missed this.  Prior to this commit the install logic
    will succeed, but the previous target_include_directories calls
    with $<INSTALL_INTERFACE> evaluate variables not yet defined.
    
    Previously:
    
    ```cmake
    set_target_properties(nanogui PROPERTIES
      INTERFACE_COMPILE_DEFINITIONS
    "NANOGUI_USE_OPENGL;NANOGUI_SHARED;NVG_SHARED"
      INTERFACE_INCLUDE_DIRECTORIES "/nanovg"
      INTERFACE_LINK_LIBRARIES "glfw"
    )
    ```
    
    where `/nanovg` does not exist, for example.  Now (fixed):
    
    ```cmake
    set_target_properties(nanogui PROPERTIES
      INTERFACE_COMPILE_DEFINITIONS
    "NANOGUI_USE_OPENGL;NANOGUI_SHARED;NVG_SHARED"
      INTERFACE_INCLUDE_DIRECTORIES
    "${_IMPORT_PREFIX}/include;${_IMPORT_PREFIX}/include/nanovg"
      INTERFACE_LINK_LIBRARIES "glfw"
    )
    ```
    svenevs committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    31fd095 View commit details
    Browse the repository at this point in the history