This repository has been archived by the owner on Jul 31, 2020. It is now read-only.
Fix/circular #67
Closed
Fix/circular #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProbablePrime
requested review from
SimonSchick and
connor4312
and removed request for
SimonSchick
connor4312
reviewed
Jun 8, 2017
| @@ -339,7 +341,8 @@ export class InteractiveSocket extends EventEmitter { | |||
| } | |||
|
|
|||
| private sendRaw(packet: any) { | |||
| const data = JSON.stringify(packet); | |||
| // Replace circular references with nothing. | |||
| const data = stringify(packet, null, 0, () => {/** */}); | |||
There was a problem hiding this comment.
The only recursive data structure that is specified on the protocol is the memory warning structure the server sends. Sending any recursive packet is going to be invalid. I think that throwing an error is the right thing to do here.
There was a problem hiding this comment.
Some people are literally doing something like:
control.text='blah'
contro.progress = 1.0
client.updateControls({sceneID:'blah',controls:[control]);
Which leads to the circular as control has a ref to scene.
Should we instead add a toJSON to each tree area that strips out circulars?
There was a problem hiding this comment.
Alright doing that. woot
|
Will re-open with toJSON'ing sometime later |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #37
Simply replaces circular references with nothing within our socket handling logic. This is handy for some issues i've seen in 3rd party projects who are not aware of some of the circular references our internal state store has.
I wish i'd saved the original example but cannot locate it.