Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this duplicating native functionality? #28

Open
falcononrails opened this issue Feb 29, 2024 · 1 comment
Open

Is this duplicating native functionality? #28

falcononrails opened this issue Feb 29, 2024 · 1 comment

Comments

@falcononrails
Copy link

falcononrails commented Feb 29, 2024

I stumbled upon this feature in nodemailer. The option attachDataUrls needs to be passed for it to add the images as attachments.
Doesn't this library serve the same purpose? Unless the native feature doesn't handle base64 encoding explicitly and that's what this library achieves?

@falcononrails
Copy link
Author

I just tested attachDataUrls with an img tag that contains base64: the resulting email contains the image rendered correctly. So I guess yes, nodemailer now natively supports this lib's functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant