use proper variable as index for array access

mjaschen · Dec 3, 2023 · dab4044 · dab4044
1 parent 7e7fa6a
commit dab4044
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,9 +15,15 @@ Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) princip
 - `setPoint1()` and `setPoint2()` methods from `Line`
 - `setSeparator()`, `useCardinalLetters()` and `setUnits()` methods from `DMS`
 
-## [4.2.0] - Current Version, 2022-07-25
+## [4.2.1] - 2023-12-03
 
-## Changed
+### Changed
+
+- use proper variable as index for array access 
+
+## [4.2.0] - 2022-07-25
+
+### Changed
 
 - point-to-line distance is calculated iteratively now, fixes #92
 - improved intersection checking for polygon/polygon

diff --git a/src/Polygon.php b/src/Polygon.php
@@ -114,7 +114,7 @@ public function getSegments(): array
 
         // to close the polygon we have to add the final segment between
         // the last point and the first point
-        $segments[] = new Line($this->points[$i - 1], $this->points[0]);
+        $segments[] = new Line($this->points[$length - 1], $this->points[0]);
 
         return $segments;
     }