WebAPI / Incoming webhooks - missing ContentDisposition in Structure

[morki]

Hey @mjl- ,

thank you again for such a great project. I have some trouble with using incoming webhooks for our system.
Specifically we are missing ContentDisposition and ContentDispositionParams fields to construct representation of email with attachments for our delivery queue. Is it possible to add those please?

https://pkg.go.dev/github.com/mjl-/[email protected]/webhook#Structure

Desired state

type Structure struct {
        ....
	ContentDisposition       string            // Lower case (nullable), e.g. attachment 
	ContentDispositionParams map[string]string // Lower case keys, original case values, e.g. {"filename": test.pdf"}.
}

[mjl-]

Hi @morki! Yeah, this makes sense. I'll look into adding it soonish.

[mjl-]

@morki the commit above adds the ContentDisposition word ("attachment", "inline"), and instead of the ContentDispositionParams, it adds a "Filename" field. this is due to differences in where email clients put the filename, and in which encoding. could you see if this works for you?

See https://www.xmox.nl/b/#42793834f8b6112a40e0ee9508c40c6e1798d23d for a binary with this commit.

[morki]

Thank you @mjl- for so fast reply and sorry for my late, I was on vacations. I tried the binary you created, The ContentDisposition seems fine, but the Filename is always empty in my tests (event sending from webmail in other mox instance).

{
  "ContentType": "application/pdf",
  "ContentTypeParams": {},
  "ContentID": "",
  "ContentDisposition": "attachment",
  "Filename": "",
  "DecodedSize": 200966,
  "Parts":[]
}