Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with batch size in _batched_map and _batched_map_with_contraction #319

Open
DSilva27 opened this issue Feb 18, 2025 · 2 comments · May be fixed by #320
Open

Fix bug with batch size in _batched_map and _batched_map_with_contraction #319

DSilva27 opened this issue Feb 18, 2025 · 2 comments · May be fixed by #320
Assignees
@DSilva27
Labels
bug Something isn't working

Comments

@DSilva27
Copy link
Collaborator

Not sure if this is worth it. I will implement it and check its performance.
@DSilva27 DSilva27 self-assigned this Feb 18, 2025
@mjo22
Copy link
Owner

mjo22 commented Feb 18, 2025

If you have the time, it would be good to check this in the 3D version as well. No worries if not

@DSilva27 DSilva27 changed the title Change batched_map_contraction in atom_potential_integrator for jax lax map Fix bug with batch size in _batched_map and _batched_map_with_contraction Feb 18, 2025
@DSilva27
Copy link
Collaborator Author

Working on this issue I realized that it already was how I visualized it, but found a small bug regarding the number of batches used

@DSilva27 DSilva27 linked a pull request Feb 19, 2025 that will close this issue
fix small bug in batched_map functions #320
Open
@DSilva27 DSilva27 added the bug Something isn't working label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DSilva27 DSilva27

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix small bug in batched_map functions mjo22/cryojax
2 participants
@mjo22 @DSilva27