From d01568e1343b16fa04b92f81853e93611f43aa12 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Tue, 26 Mar 2024 20:35:36 +0100 Subject: [PATCH] Dockerfile: `python3 setup.py install` is deprecated https://packaging.python.org/en/latest/discussions/setup-py-deprecated Let's try `pip install --editable .` instead. Also, `pip` now has a real dependency resolver to provide it all dependencies in a single command. Why not put `libmagic` and `urllib3` in `setup.py`'s `install_requires` list? --- Dockerfile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Dockerfile b/Dockerfile index 54add2ef..472266af 100644 --- a/Dockerfile +++ b/Dockerfile @@ -16,6 +16,5 @@ WORKDIR /workbench RUN python -m pip install setuptools # RUN pip install filemagic -RUN pip install urllib3>=1.21.1 -RUN pip install libmagic -RUN python setup.py install +RUN pip install libmagic urllib3>=1.21.1 +RUN pip install --editable .