Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results summarizer fails when results folder is empty #236

Open
pgmpablo157321 opened this issue May 18, 2022 · 0 comments
Open

Results summarizer fails when results folder is empty #236

pgmpablo157321 opened this issue May 18, 2022 · 0 comments

Comments

@pgmpablo157321
Copy link
Contributor

This error occurs:

Traceback (most recent call last):
File "/opt/python3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/opt/python3.9/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/layers/google.python.pip/pip/lib/python3.9/site-packages/mlperf_logging/result_summarizer/__main__.py", line 3, in <module>
result_summarizer.main()
File "/layers/google.python.pip/pip/lib/python3.9/site-packages/mlperf_logging/result_summarizer/result_summarizer.py", line 626, in main
_update_summaries(args.folder)
File "/layers/google.python.pip/pip/lib/python3.9/site-packages/mlperf_logging/result_summarizer/result_summarizer.py", line 597, in _update_summaries
strong_scaling_summary, weak_scaling_summary = summarize_results(
File "/layers/google.python.pip/pip/lib/python3.9/site-packages/mlperf_logging/result_summarizer/result_summarizer.py", line 517, in summarize_results
strong_scaling_scores = _compute_strong_scaling_scores(
File "/layers/google.python.pip/pip/lib/python3.9/site-packages/mlperf_logging/result_summarizer/result_summarizer.py", line 330, in _compute_strong_scaling_scores
benchmark_scores[benchmark] = _compute_olympic_average(
File "/layers/google.python.pip/pip/lib/python3.9/site-packages/mlperf_logging/result_summarizer/result_summarizer.py", line 185, in _compute_olympic_average
return sum_of_scores * 1.0 / len(countable_scores)
ZeroDivisionError: float division by zero

A suggested solution would be to add a previous check in package checker to avoid this "ugly" error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant