[SD] log number of samples instead of number of iterations #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
ahmadki
force-pushed
the
ahmadki/sd_iters_to_samples
branch
2 times, most recently
from
90fc1ed
to
fcb66ce
Compare
|
The PR is ready, however I'm keeping the WIP tag as I'll need to update logging library in the requirements file after mlcommons/logging#357 is merged |
ahmadki
force-pushed
the
ahmadki/sd_iters_to_samples
branch
from
fcb66ce
to
6c2f4ac
Compare
|
Looks good. We should notify the submitters that they might need to change their scripts from the last round to pass the checker. |
ahmadki
force-pushed
the
ahmadki/sd_iters_to_samples
branch
from
6c2f4ac
to
20391e0
Compare
ahmadki
changed the title
nv-rborkar
approved these changes
Feb 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR along with mlcommons/logging#357 should address mlcommons/logging#351