Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable Diffusion Dataset #751

Closed
amasin2111 opened this issue Jun 28, 2024 · 10 comments
Closed

Stable Diffusion Dataset #751

amasin2111 opened this issue Jun 28, 2024 · 10 comments

Comments

@amasin2111
Copy link

When we were trying to download the data set using the script laion400m-filtered-download-images.sh, we were getting an error that the source directory doesn't exist. Specifically, below command is failing,
"rclone copy mlc-training:mlcommons-training-wg-public/stable_diffusion/datasets/laion-400m/moments-webdataset-filtered/ ${OUTPUT_DIR} --include="*.tar" -P"

@amasin2111
Copy link
Author

Hi, were you able to get around it

@morphine00
Copy link
Contributor

@ahmadki both me and @nathanw-mlc tested the rclone commands and the scripts, and the data exists in the bucket (see attached)

What I did notice is that even the original scrips assumes that the destination directory /datasets/etcetc can be created, but unless the user is root, they won't have permissions to do so. Maybe this is the reason why it fails?

rclone-1
rclone-2

@amasin2111
Copy link
Author

Hi,
I have used the same commands but still observing the same issue
1
2

@nathanw-mlc
Copy link
Member

Can those having issues please share the result of rclone version.

@amasin2111
Copy link
Author

amasin2111 commented Jul 17, 2024

Here is the version
version

@nathanw-mlc
Copy link
Member

I just noticed that the update to the Dockerfile uses apt-get install to install Rclone. This install method installs an old version of Rclone (rclone v1.53.3-DEV) that doesn't process the rclone config create command correctly, resulting in Rclone attempting to connect to an AWS S3 bucket with the provided credentials, rather than a Cloudflare R2 bucket. Users need to be running v1.6x.x. To make that happen, the Dockerfile should install Rclone with the install command we provide for all Rclone instructions: sudo -v ; curl https://rclone.org/install.sh | sudo bash

@amasin2111
Copy link
Author

It worked for me, other users might have to clean the config files, before retrying with new rclone version

@hiwotadese
Copy link
Contributor

@ahmadki can we fix Dockerfile with @nathanw-mlc sugguestion sudo -v ; curl https://rclone.org/install.sh | sudo bash?

ahmadki added a commit to ahmadki/training that referenced this issue Aug 1, 2024
@ahmadki
Copy link
Contributor

ahmadki commented Aug 1, 2024

I genuinely dislike piping scripts from the internet into bash. Not only does it pose a security risk, but we also need to freeze rclone to a specific version.

#757 should work better.

@ShriyaPalsamudram
Copy link
Contributor

Closing because #757 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants