Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined argument "moe_freq" when running unit tests on WSL/Ubuntu 20.04 #168

Open
aaronsm opened this issue Dec 19, 2023 · 1 comment
Open
Assignees

Comments

@aaronsm
Copy link

aaronsm commented Dec 19, 2023

I'm trying OpenLM on Ubuntu 20.04 under WSL. I've hit an issue running the unit tests where the argument "moe_freq" is never set before using it in train.py which results in a Python error. As a work around I added hasattr() to line 176 in train.py:

if hasattr(args, "moe_freq") and args.moe_freq > 0:

Steps to Reproduce

open_lm/open_lm$ pytest tests/

FAILED tests/test_accumulation.py::TestGradientAccumulation::test_accumulation - AttributeError: 'Namespace' object has no attribute 'moe_freq'

@achalddave achalddave self-assigned this Dec 19, 2023
@achalddave
Copy link
Collaborator

thanks for reporting! Looks like this is in an old test that was committed to open_lm/tests instead of tests/. Feel free to ignore that test for now, and I'll move it to our tests/ folder or deprecate it entirely soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants