You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, all the interesting logic in test-runner.go is in one big switch statement in RunStep. This makes it basically impossible for compound steps to call through to individual steps. For example, fullCommit could in principle call through to commit, handlePendingCommit, handleCommit, and joinGroup, but instead it replicates all the logic of those methods.
The text was updated successfully, but these errors were encountered:
One thing that might be helpful here is to leverage the Go type system more, for example by decoding script steps into typed values. Then you could have a bunch of RunFooStep(step FooStep) methods that would presumably be easier to chain.
Right now, all the interesting logic in
test-runner.go
is in one bigswitch
statement inRunStep
. This makes it basically impossible for compound steps to call through to individual steps. For example,fullCommit
could in principle call through tocommit
,handlePendingCommit
,handleCommit
, andjoinGroup
, but instead it replicates all the logic of those methods.The text was updated successfully, but these errors were encountered: