Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe remove calls to set.seed and torch_manual_seed() from the tests #1238

Open
sebffischer opened this issue Jan 16, 2025 · 2 comments
Open

Comments

@sebffischer
Copy link
Collaborator

If we set the seeds in the tests, everything afterwards is deterministic. For some tests that randomly generate data, it would maybe be better to have them be executed randomly to increase the test coverage.

@dfalbel
Copy link
Member

dfalbel commented Jan 16, 2025

This will be a significant amount of work to implement given how it currently expects.

@sebffischer
Copy link
Collaborator Author

sebffischer commented Jan 20, 2025

What I mean with the issue is that one could instead using something like with_torch_local_seed(...) to make the subsequent tests not deterministic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants