From 15c0dbd3bbe4dae46301acfc1cc6e7de5b856509 Mon Sep 17 00:00:00 2001
From: Matthieu Maitre <mmaitre@live.com>
Date: Fri, 13 Sep 2024 08:17:05 -0700
Subject: [PATCH] Mark debugger modules as unsafe (#29)

* Mark debuggers as dangerous

* lint

---------

Co-authored-by: Matthieu Maitre <mmaitre314@users.noreply.github.com>
---
 setup.cfg                   |   2 +-
 src/picklescan/scanner.py   |   3 +++
 tests/data/malicious14.pkl  | Bin 0 -> 53 bytes
 tests/data/malicious15a.pkl | Bin 0 -> 175 bytes
 tests/data/malicious15b.pkl | Bin 0 -> 134 bytes
 tests/test_scanner.py       |  22 +++++++++++++++++++---
 6 files changed, 23 insertions(+), 4 deletions(-)
 create mode 100644 tests/data/malicious14.pkl
 create mode 100644 tests/data/malicious15a.pkl
 create mode 100644 tests/data/malicious15b.pkl

diff --git a/setup.cfg b/setup.cfg
index dff8e15..c52dab0 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -1,6 +1,6 @@
 [metadata]
 name = picklescan
-version = 0.0.16
+version = 0.0.17
 author = Matthieu Maitre
 author_email = mmaitre314@users.noreply.github.com
 description = Security scanner detecting Python Pickle files performing suspicious actions
diff --git a/src/picklescan/scanner.py b/src/picklescan/scanner.py
index 145bd49..08965ed 100644
--- a/src/picklescan/scanner.py
+++ b/src/picklescan/scanner.py
@@ -114,10 +114,13 @@ def __str__(self) -> str:
     "socket": "*",
     "subprocess": "*",
     "sys": "*",
+    "shutil": "*",
     "runpy": "*",  # Includes runpy._run_code
     "operator": "attrgetter",  # Ex of code execution: operator.attrgetter("system")(__import__("os"))("echo pwned")
     "pickle": "*",
     "_pickle": "*",
+    "bdb": "*",
+    "pdb": "*",
 }
 
 #
diff --git a/tests/data/malicious14.pkl b/tests/data/malicious14.pkl
new file mode 100644
index 0000000000000000000000000000000000000000..478ddf1b317c309db12016af09493eab73cc34dd
GIT binary patch
literal 53
zcmZo*nX1JA0X?imrFjLFQ+hb#fsFX%{FKxwlc)6X6clCVm1wA&n3}0;PHCMIG(`^p
Dsap|g

literal 0
HcmV?d00001

diff --git a/tests/data/malicious15a.pkl b/tests/data/malicious15a.pkl
new file mode 100644
index 0000000000000000000000000000000000000000..8a366becacf9ca620cd2fc93763946de487ca105
GIT binary patch
literal 175
zcmWlOy$*sf7)6U9X#L>{Obin&JcJLxz|^g2YlQ||_}UWVK%xuJZ5>W>&pn@wpp?(*
z>6M`rchWQOEe0g`o#R^oA`&Bn>}+7OLfk^qN7Wa$3#27ULUDtdAZth(Hn)-u4t5Ld
zNf!KJ1QWdkyug9v|HCpZsg-`VMwt$d&CJOq1f{3Z`s?WM=xX<NUh1-V^&``&sNl51
IxrMy`0ijGY^Z)<=

literal 0
HcmV?d00001

diff --git a/tests/data/malicious15b.pkl b/tests/data/malicious15b.pkl
new file mode 100644
index 0000000000000000000000000000000000000000..a7fda5bc492ef5b05ecccc5e4d10b6038508cf53
GIT binary patch
literal 134
zcmZo*nOe;N0X@t~DM?d$*qu_6^omOJrc9oa!O+7D<N;ZljZ<o;X!NiYXJ-~n@#|qr
zDoRbvE(VJAu&3oECnjg4g4q0NMTxno@kOa6rA2v}dFfO9N|SnIGjj{_i%Jyoi@EZP
c^@=NtOHy++l*%*m6LT|_G^eyp37Vn@0HiW9KL7v#

literal 0
HcmV?d00001

diff --git a/tests/test_scanner.py b/tests/test_scanner.py
index c34948e..40f6e27 100644
--- a/tests/test_scanner.py
+++ b/tests/test_scanner.py
@@ -1,4 +1,5 @@
 import aiohttp
+import bdb
 import http.client
 import importlib
 import io
@@ -89,6 +90,15 @@ def __reduce__(self):
         return runpy._run_code, ("print('456')",)
 
 
+class Malicious15:
+    def __reduce__(self):
+        bd = bdb.Bdb()
+        return bdb.Bdb.run, (
+            bd,
+            'import os\nos.system("whoami")',
+        )
+
+
 class HTTPResponse:
     def __init__(self, status, data=None):
         self.status = status
@@ -345,6 +355,8 @@ def initialize_pickle_files():
     initialize_pickle_file(
         f"{_root_path}/data/malicious14.pkl", Malicious14(), 4
     )  # runpy
+    initialize_pickle_file(f"{_root_path}/data/malicious15a.pkl", Malicious15(), 2)
+    initialize_pickle_file(f"{_root_path}/data/malicious15b.pkl", Malicious15(), 4)
 
     initialize_zip_file(
         f"{_root_path}/data/malicious1.zip",
@@ -590,6 +602,7 @@ def test_scan_directory_path():
             Global("__builtin__", "dict", SafetyLevel.Suspicious),
             Global("__builtin__", "apply", SafetyLevel.Dangerous),
             Global("__builtin__", "getattr", SafetyLevel.Dangerous),
+            Global("__builtin__", "getattr", SafetyLevel.Dangerous),
             Global("__builtin__", "globals", SafetyLevel.Suspicious),
             Global("requests.api", "get", SafetyLevel.Dangerous),
             Global("builtins", "eval", SafetyLevel.Dangerous),
@@ -610,10 +623,13 @@ def test_scan_directory_path():
             Global("pickle", "loads", SafetyLevel.Dangerous),
             Global("_pickle", "loads", SafetyLevel.Dangerous),
             Global("_codecs", "encode", SafetyLevel.Suspicious),
+            Global("bdb", "Bdb", SafetyLevel.Dangerous),
+            Global("bdb", "Bdb", SafetyLevel.Dangerous),
+            Global("bdb", "Bdb.run", SafetyLevel.Dangerous),
         ],
-        scanned_files=28,
-        issues_count=26,
-        infected_files=23,
+        scanned_files=30,
+        issues_count=30,
+        infected_files=25,
         scan_err=True,
     )
     compare_scan_results(scan_directory_path(f"{_root_path}/data/"), sr)