-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix units in sizeof_fmt #12962
Fix units in sizeof_fmt #12962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but then we have to switch to base 1000, because currently we are using base 1024 (e.g. 1 kB = 1000 bytes, but 1 kiB = 1024 bytes). I'm fine either way. |
This was discussed before in regards to the sys_info output and we settled on GiB so let's be consistent and stick with that here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one capitalization fix in the changelog entry
Co-authored-by: Daniel McCloy <[email protected]>
I'll fix the tests this afternoon! |
I will definitely never understand Sphinx, so I'd be happy if someone fixed this reference not found issue for me. Thanks! |
Fixes #12961.