Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem in loading icons #25

Open
Mahmoud-AbouDeghedy opened this issue Mar 26, 2023 · 2 comments
Open

Problem in loading icons #25

Mahmoud-AbouDeghedy opened this issue Mar 26, 2023 · 2 comments

Comments

@Mahmoud-AbouDeghedy
Copy link

Mahmoud-AbouDeghedy commented Mar 26, 2023 •
edited
Loading

I suggest adding this line in the header section:

<head>
  <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css">
</head>

as the icons didn't appear in my browsers (tried Edge & Firefox).
Any way a huge Thank U for this nice template.
@peetjvv
Copy link

peetjvv commented Nov 30, 2023 •
edited
Loading

Thank you for this suggested fix. Note that it's only for v4 and Font Awesome is currently on v6. I was unable to get the v6 icons to show in the rendered web page (on Firefox), but I know Font Awesome changed some things with v6 so aren't surprised.

Here's the link to the v6.5.0 stylesheet: https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.0/css/fontawesome.min.css

And if you still want to use the git module, then you have to specify the 6.x branch in the .gitmodules file and change the stylesheet link to dep/Font-Awesome/free/css/fontawesome.css. Although I wasn't able to fully get this working either. CSS loads, but no icons are shown.

@jmpolom
Copy link

jmpolom commented Jan 10, 2024

Try: <link rel="stylesheet" type="text/css" href="dep/Font-Awesome/css/all.css" />

The class for the LinkedIn icon also needs to be adjusted to fa-brands. This worked for me with FA 6.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmpolom @peetjvv @Mahmoud-AbouDeghedy