Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate IObserverOptions options and its properties in JSDoc #3939

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

imjordanxd
Copy link
Contributor

Added some JSDoc that marks IObserverOptions as deprecated along with its individual properties. This gives some developers some feedback inside their editors instead of console.warn messages at runtime.

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: 71f03ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@imjordanxd imjordanxd changed the title deprecate IObserver options and its properties in JSDoc deprecate IObserverOptions options and its properties in JSDoc Oct 15, 2024
@mweststrate
Copy link
Member

Thanks!

@mweststrate mweststrate merged commit 51354c2 into mobxjs:main Oct 15, 2024
1 check passed
mweststrate added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants