Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move file I/O of ModelicaStandardTables to ModelicaIO #2192

Closed
beutlich opened this issue Feb 27, 2017 · 1 comment
Closed

Move file I/O of ModelicaStandardTables to ModelicaIO #2192

beutlich opened this issue Feb 27, 2017 · 1 comment
Assignees
@beutlich
Labels
enhancement New feature or enhancement L: Blocks Issue addresses Modelica.Blocks L: C-Sources Issue addresses Modelica/Resources/C-Sources V: 3.2.2 Issue originates in MSL v3.2.2 (and is not present in earlier releases)
Milestone
MSL3.2.3

Comments

@beutlich
Copy link
Member

beutlich commented Feb 27, 2017 •
edited
Loading

In UdK-VPT/BuildingSystems#12 (comment) it was discussed that the file I/O (i.e., functions readTxtTable and readMatTable) of the ModelicaStandardTables could be decoupled from the core table features being interpolation and extrapolation. With ModelicaIO (of MSL v3.2.2) already supporting reading MAT files the implementation basics and infrastructure are already available.

@mwetter @thorade FYI.
@beutlich beutlich added enhancement New feature or enhancement L: C-Sources Issue addresses Modelica/Resources/C-Sources V: 3.2.2 Issue originates in MSL v3.2.2 (and is not present in earlier releases) labels Feb 27, 2017
@beutlich beutlich self-assigned this Feb 27, 2017
@beutlich beutlich added this to the MSL_next-MINOR-version milestone Mar 13, 2017
@beutlich beutlich added the L: Blocks Issue addresses Modelica.Blocks label Mar 13, 2017
beutlich added a commit that referenced this issue Mar 13, 2017
@beutlich
refs #2192: Restructure ModelicaIO
7ac5e51 
* Move file I/O of ModelicaStandardTables to ModelicaIO, i.e., ModelicaStandardTables no longer directly depends on ModelicaMatIO (only via ModelicaIO)
* Create new API function ModelicaIO_readRealTable that is called from ModelicaStandardTables (Note: Impossible to call
ModelicaIO_readRealTable from a Modelica environment)
* Move common code of ModelicaIO_readMatrixSizes and ModelicaIO_readRealMatrix (as well as ModelicaIO_readRealTable) to new internal function readMatIO
@beutlich
Copy link
Member Author

Resolved by 7ac5e51 in master.

beutlich added a commit that referenced this issue Mar 27, 2017
@beutlich
refs #2220, #2192: Fix argument order in ModelicaIO.c
65547e6
beutlich added a commit that referenced this issue Jan 24, 2018
@beutlich
refs #2192: MSVC: Avoid heap corruption
075b560 
Avoid heap corruption if ModelicaIO.dll and ModelicaStandardTables.dll are built with different VC run-time options. Free the table in the same address space where it was allocated earlier.
@beutlich beutlich mentioned this issue Feb 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beutlich beutlich

Labels
enhancement New feature or enhancement L: Blocks Issue addresses Modelica.Blocks L: C-Sources Issue addresses Modelica/Resources/C-Sources V: 3.2.2 Issue originates in MSL v3.2.2 (and is not present in earlier releases)
Projects
None yet
Milestone
MSL3.2.3
Development

No branches or pull requests
1 participant
@beutlich