Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(enhanced): layers support #3241

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat(enhanced): layers support #3241

wants to merge 6 commits into from

Conversation

ScriptedAlchemy
Copy link
Member

Description

Suport loader and entry layers for shared modules

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Nov 17, 2024

⚠️ No Changeset found

Latest commit: aed08e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit aed08e9
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/673fd981f955520008fe9422
😎 Deploy Preview https://deploy-preview-3241--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

/**
* Share a specific layer of the module, if the module supports layers.
*/
layer?: string | null;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need to see about layer/issuerlayer

we can add layer, but this will not make match unless it is same as consumed module - however i can get issuerLayer and build request map with that?

// module request
unresolved.set(request, config);
unresolved.set(req, config);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here i can construct contextInfo.issuerLayer from parent module - but we do not know layer it would become because this takes place in factorize of the module iteself, so i can make keys of ( issuerLayer )+ request. like (loader-layer)react as key.

then anything with issuerLayer of that, react request will match the request - which i think is correct use case here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant