-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(enhanced): layers support #3241
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# Conflicts: # pnpm-lock.yaml
f20b379
to
3e59c55
Compare
# Conflicts: # pnpm-lock.yaml
/** | ||
* Share a specific layer of the module, if the module supports layers. | ||
*/ | ||
layer?: string | null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i need to see about layer/issuerlayer
we can add layer, but this will not make match unless it is same as consumed module - however i can get issuerLayer and build request map with that?
// module request | ||
unresolved.set(request, config); | ||
unresolved.set(req, config); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here i can construct contextInfo.issuerLayer from parent module - but we do not know layer it would become because this takes place in factorize of the module iteself, so i can make keys of ( issuerLayer )+ request. like (loader-layer)react as key.
then anything with issuerLayer of that, react request will match the request - which i think is correct use case here
Description
Suport loader and entry layers for shared modules
Related Issue
Types of changes
Checklist