Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inactive albums no longer faded out in tree? (Gallery 1.7.0 / MODX 2.3.1) #45

Closed
pixelchutes opened this issue Sep 12, 2014 · 3 comments · May be fixed by #58
Closed

Inactive albums no longer faded out in tree? (Gallery 1.7.0 / MODX 2.3.1) #45

pixelchutes opened this issue Sep 12, 2014 · 3 comments · May be fixed by #58
Labels
stale

Comments

@pixelchutes
Copy link

Previously if you had an Album that was not flagged as "Active", there was a visual differentiation in the tree (the inactive albums were slightly faded out)

It seems this is no longer the case with the most recent Gallery release?
@pixelchutes
Copy link
Author

Specifically, it seems .gal-item-inactive is no longer being applied in right spot for inactive albums in the tree.

Not sure of the implications here, but this seemed to do the trick in core/components/gallery/processors/mgr/album/getnodes.class.php:

if ($version['major_version'] < 3) {
    $albumArray['cls'] = 'icon-tiff'.($album->get('active') ? '' : ' gal-item-inactive');
} else {
    $albumArray['iconCls'] = 'icon icon-tiff'.($album->get('active') ? '' : ' gal-item-inactive');
    $albumArray['cls'] = ($album->get('active') ? '' : ' gal-item-inactive'); // <-- Added this line
}

pixelchutes added a commit to pixelchutes/Gallery that referenced this issue Feb 6, 2015
@pixelchutes
Restores missing .gal-item-inactive class on inactive parent albums
c1ac390 
Fixes modxcms#45
@pixelchutes pixelchutes mentioned this issue Feb 6, 2015
Open
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jul 16, 2022
@github-actions
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restores missing .gal-item-inactive class on inactive parent albums pixelchutes/Gallery
1 participant
@pixelchutes