Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect License Metadata in Nuspec File #16

Closed
regnrat opened this issue Mar 22, 2023 · 4 comments · Fixed by #17
Closed

Incorrect License Metadata in Nuspec File #16

regnrat opened this issue Mar 22, 2023 · 4 comments · Fixed by #17

Comments

@regnrat
Copy link
Contributor

regnrat commented Mar 22, 2023

I've noticed that the nuspec file has incorrect metadata for the license and licenseUrl properties. Specifically, the license property is set to LICENSE, but the correct license for this package is MIT. Additionally, the licenseUrl property is set to https://aka.ms/deprecateLicenseUrl, but the correct URL for this license is eg. https://licenses.nuget.org/MIT.

This issue is causing problems for me because I want to set up an automatic license check in my project.
I would appreciate it if the package maintainer could update the nuspec file to reflect the correct license and URL.

Expected result:
The nuspec file should have correct metadata for the license and licenseUrl properties.

Actual result:
The nuspec file has incorrect metadata for the license and licenseUrl properties.

@molinch
Copy link
Owner

molinch commented Mar 22, 2023

Thanks @regnrat for spotting this!
Would you have time for a small PR? Otherwise it will wait for a couple of days until I fix it

@regnrat
Copy link
Contributor Author

regnrat commented Mar 22, 2023

Sure @molinch, i opened a PR - but I was not able to get that working without replacing the PackageLicenseFile with PackageLicenseExpression

@molinch
Copy link
Owner

molinch commented Mar 22, 2023

Thanks a lot @regnrat it's 👍
In fact it should have been PackageLicenceExpression from the start, as per https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/nuget

@molinch
Copy link
Owner

molinch commented Mar 22, 2023

Package 1.5.1 is pushed despite the CI error due to underlying issue brandedoutcast/publish-nuget#76

@molinch molinch reopened this Mar 22, 2023
@molinch molinch closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants