Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified server and client build #56

Open
Jack5079 opened this issue Mar 9, 2024 · 8 comments · May be fixed by #60
Open

Unified server and client build #56

Jack5079 opened this issue Mar 9, 2024 · 8 comments · May be fixed by #60
Assignees

Comments

@Jack5079
Copy link
Member

Jack5079 commented Mar 9, 2024

Hono's official templates build the server using Vite. We should too.

Benefits include:

@Jack5079 Jack5079 self-assigned this Mar 9, 2024
@Jack5079
Copy link
Member Author

Jack5079 commented Mar 9, 2024

@nbitzz should this be in 2.0 or 2.1

@nbitzz
Copy link
Contributor

nbitzz commented Mar 9, 2024

@nbitzz should this be in 2.0 or 2.1

Your choice

@Jack5079 Jack5079 linked a pull request Apr 21, 2024 that will close this issue
@nbitzz
Copy link
Contributor

nbitzz commented Apr 26, 2024

@Jack5079 Should we just trash the client and make a new one, it's a mess

@Jack5079
Copy link
Member Author

@Jack5079 Should we just trash the client and make a new one, it's a mess

I could try, would fit with monokit

New client will almost certainly be multipage are there any characters you can't use in a file ID so I can prefix the pages with them

@Jack5079
Copy link
Member Author

Jack5079 commented Apr 26, 2024

@Jack5079 Should we just trash the client and make a new one, it's a mess

I could try, would fit with monokit

New client will almost certainly be multipage are there any characters you can't use in a file ID so I can prefix the pages with them

Idea: fyle.uk/-/settings

@nbitzz
Copy link
Contributor

nbitzz commented Apr 26, 2024

New client will almost certainly be multipage are there any characters you can't use in a file ID so I can prefix the pages with them

Not many; but we can remove some...

@nbitzz
Copy link
Contributor

nbitzz commented Apr 26, 2024

@Jack5079 Should we just trash the client and make a new one, it's a mess

I could try, would fit with monokit
New client will almost certainly be multipage are there any characters you can't use in a file ID so I can prefix the pages with them

Idea: fyle.uk/-/settings

That works too

@nbitzz
Copy link
Contributor

nbitzz commented Apr 26, 2024

We could always just use /settings anyway, I never gave any guarantees that /:fileId would work for any ID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants