-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AssertionError: false == true #228
Comments
Getting the same issue:
My server:
My client:
|
Getting this as well with node-apn: Node version: 6.9.1
|
+1 |
+1 |
3 similar comments
+1 |
+1 |
+1 |
@molnarg Pls. |
+1 |
3 similar comments
+1 |
+1 |
+1 |
@nwgh Also have seen this assert when running Looking at the call to
Here's the code for In the case where
|
+1 |
1 similar comment
+1 |
Fixes molnarg#228 In the case where this._push(frame) returns null (i.e., the frame is too large for the window and split or the window size is <=0), moreNeeded will be set to null. Then this._queue.push(frame) is called, but moreNeeded is still null. Thus, any time the window is <=0 or the frame is split we'll hit the assert: var moreNeeded = null; if (this._queue.length === 0) { moreNeeded = this._push(frame); } if (moreNeeded === null) { this._queue.push(frame); } return moreNeeded; Credit goes to @jrabek for original version of this patch
Fixes molnarg#228 In the case where this._push(frame) returns null (i.e., the frame is too large for the window and split or the window size is <=0), moreNeeded will be set to null. Then this._queue.push(frame) is called, but moreNeeded is still null. Thus, any time the window is <=0 or the frame is split we'll hit the assert: var moreNeeded = null; if (this._queue.length === 0) { moreNeeded = this._push(frame); } if (moreNeeded === null) { this._queue.push(frame); } return moreNeeded; Credit goes to @jrabek for original version of this patch
+1 |
2 similar comments
+1 |
+1 |
same problem. |
node -v 6.9.2
[email protected]
My server.js
and boot.js (clustering) - http://pastebin.com/YzGsJVUk
The text was updated successfully, but these errors were encountered: