feat: Make the cloud linter start and end dates configurable #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nand4011
force-pushed
the
linter-configurable-duration
branch
from
fcd2c37
to
447cf56
Compare
cprice404
reviewed
Aug 1, 2024
There was a problem hiding this comment.
couple of minor questions / nits that probably aren't blockers.
We may want @eaddingtonwhite to pull down and run it before merging, if he has time.
Add optional arguments to the cloud-linter command that take a start and end date in YYYY-MM-DD form. If the start-date isn't provided, it defaults to end-date - 30. If end-date isn't provided, it defaults to today. Make the process resources function argument orders consistent. Delete some commented out code.
nand4011
force-pushed
the
linter-configurable-duration
branch
from
078ab2d
to
0ab862b
Compare
Ignore too many arguments lint errors. This needs to be fixed, but it would be a larger change and I want to unblock.
nand4011
force-pushed
the
linter-configurable-duration
branch
from
0ab862b
to
1aad9c2
Compare
|
@malandis to pull this down and help review UX if he gets to it before I do. |
malandis
reviewed
Aug 7, 2024
malandis
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional arguments to the cloud-linter command that take a start and end date in YYYY-MM-DD form. If the start-date isn't provided, it defaults to end-date - 30. If end-date isn't provided, it defaults to today.
Make the process resources function argument orders consistent.
Delete some commented out code.