Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile incompatible with Poetry 2 #962

Open
ptgolden opened this issue Feb 25, 2025 · 2 comments · May be fixed by #964
Open

Makefile incompatible with Poetry 2 #962

ptgolden opened this issue Feb 25, 2025 · 2 comments · May be fixed by #964
Assignees
@ptgolden

Comments

@ptgolden
Copy link
Member

In Poetry 2, the -C flag actually changes directories rather than just using the specified directory as the location of the Poetry environment. Some commands in our Makefile depend on not changing directories.

The options for fixing this are:

  1. Use the new --project flag when Poetry 2 is detected (and use -C for Poetry 1)
  2. Still use -C but use absolute paths for directories in CLI commands rather than depending on being in the root directory
  3. Remove usage of -C, prepend any poetry invocation with cd backend &&, and assume $CWD will always be monarch_app/backend
@ptgolden ptgolden self-assigned this Feb 25, 2025
@ptgolden ptgolden linked a pull request Feb 25, 2025 that will close this issue
Open
@ptgolden
Copy link
Member Author

I ended up going with option 3 in #964

@amc-corey-cox
Copy link
Collaborator

#966 is a duplicate of this

@amc-corey-cox amc-corey-cox mentioned this issue Feb 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptgolden ptgolden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the makefile work with Poetry v2 as well as v2 monarch-initiative/monarch-app
2 participants
@ptgolden @amc-corey-cox