From 0042c7f20e8f3a4cc8a85ac388501aa1a4248e18 Mon Sep 17 00:00:00 2001 From: Maria Zadnepryanets Date: Sun, 20 Oct 2024 15:42:12 +0200 Subject: [PATCH 1/3] fix: EditableText and EditableHeading overflowing in the catalog --- .../EditableTypography/EditableTypography.module.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/components/EditableTypography/EditableTypography.module.scss b/packages/core/src/components/EditableTypography/EditableTypography.module.scss index 1e2919eaf3..84a54ff9af 100644 --- a/packages/core/src/components/EditableTypography/EditableTypography.module.scss +++ b/packages/core/src/components/EditableTypography/EditableTypography.module.scss @@ -1,7 +1,7 @@ @import "~monday-ui-style/dist/mixins"; .editableTypography { - display: inline-flex; + display: contents; min-width: 0; max-width: 100%; // Shifts the component to align the text with the container From 2160a7808a390871058f338c2faa062bfce7b30d Mon Sep 17 00:00:00 2001 From: Maria Zadnepryanets Date: Mon, 21 Oct 2024 14:45:56 +0200 Subject: [PATCH 2/3] fix: .editableTypography set display to block and add missing 6px to max-width --- .../EditableTypography/EditableTypography.module.scss | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/core/src/components/EditableTypography/EditableTypography.module.scss b/packages/core/src/components/EditableTypography/EditableTypography.module.scss index 84a54ff9af..3fe524b8b8 100644 --- a/packages/core/src/components/EditableTypography/EditableTypography.module.scss +++ b/packages/core/src/components/EditableTypography/EditableTypography.module.scss @@ -1,11 +1,12 @@ @import "~monday-ui-style/dist/mixins"; .editableTypography { - display: contents; + display: block; min-width: 0; - max-width: 100%; // Shifts the component to align the text with the container margin-left: -6px; + // Adds 6 px removed above to the element width to avoid unnecessary overflow + max-width: calc(100% + 6px); overflow: hidden; position: relative; From d326d8d8fa7a3fa87fb166ab837de9331b87a646 Mon Sep 17 00:00:00 2001 From: Maria Zadnepryanets Date: Wed, 6 Nov 2024 12:52:49 +0100 Subject: [PATCH 3/3] fix: revert display of .editableTypography to inline-flex to fix jumping editeble field, when editing --- .../EditableTypography/EditableTypography.module.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/components/EditableTypography/EditableTypography.module.scss b/packages/core/src/components/EditableTypography/EditableTypography.module.scss index 3fe524b8b8..ef4a1355f4 100644 --- a/packages/core/src/components/EditableTypography/EditableTypography.module.scss +++ b/packages/core/src/components/EditableTypography/EditableTypography.module.scss @@ -1,7 +1,7 @@ @import "~monday-ui-style/dist/mixins"; .editableTypography { - display: block; + display: inline-flex; min-width: 0; // Shifts the component to align the text with the container margin-left: -6px;