Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-upload: fix ssh ClientAliveCountMax check #461 #467

Closed
wants to merge 3 commits into from

Conversation

mm-weber
Copy link
Contributor

@mm-weber mm-weber commented Jan 15, 2025

No description provided.

@mm-weber mm-weber self-assigned this Jan 15, 2025

This comment has been minimized.

Signed-off-by: Manuel Weber <[email protected]>

This comment has been minimized.

Signed-off-by: Manuel Weber <[email protected]>
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ forbidden-pattern 14

See ❌ Event descriptions for more information.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (198) from .github/actions/spelling/expect.txt and unrecognized words (0)

Dictionary Entries Covers Uniquely
cspell:node/dict/node.txt 891 9 3
cspell:k8s/dict/k8s.txt 153 3 3
cspell:php/dict/php.txt 1689 7 1
cspell:django/dict/django.txt 393 4 1
cspell:golang/dict/go.txt 2099 3 1

Consider adding them (in .github/workflows/spell-check.yaml) in jobs:/spelling: for uses: check-spelling/[email protected] in its with:

      with:
        extra_dictionaries: |
          cspell:node/dict/node.txt
          cspell:k8s/dict/k8s.txt
          cspell:php/dict/php.txt
          cspell:django/dict/django.txt
          cspell:golang/dict/go.txt

To stop checking additional dictionaries, add (in .github/workflows/spell-check.yaml) for uses: check-spelling/[email protected] in its with:

check_extra_dictionaries: ''
Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

find spaces before a comma

( )+,
If the flagged items are false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@@ -1318,7 +1318,7 @@ queries:
- uid: mondooLinuxSecurityAuditFiles
title: Return the content from all /etc/audit/rules.d and /etc/audit/audit.rules
mql: |
mondooLinuxSecurityAuditFiles = files.find(from: "/etc/audit/rules.d",regex:'.*\.rules$', type: "file").list.map(path) + ["/etc/audit/audit.rules"]
mondooLinuxSecurityAuditFiles = files.find(from: "/etc/audit/rules.d",regex:'.*\.rules$' , type: "file").list.map(path) + ["/etc/audit/audit.rules"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, having a space before a comma reads not well.

@mm-weber
Copy link
Contributor Author

replaced by #469

@mm-weber mm-weber closed this Jan 20, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants