Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use our own custom Jekyll-Multiple-Languages-Plugin #2317

Open
plowsof opened this issue Jul 9, 2024 · 2 comments · May be fixed by #2237
Open

use our own custom Jekyll-Multiple-Languages-Plugin #2317

plowsof opened this issue Jul 9, 2024 · 2 comments · May be fixed by #2237

Comments

@plowsof
Copy link
Collaborator

plowsof commented Jul 9, 2024

prefacing this by saying i don't know what ruby or gems are.

please read 2140 for more context:

we are currently forced to use ruby < 3.2.0 which is not good for long term as Ruby EOL's versions frequently

Starting in Ruby 3.2.0 the exists? (pluralized) alias for exist? seems to has been removed.

Now to my request. So before i can even attempt to fix the lowest hanging fruit "exists?" -> "exist?" issue, i need to use/import a custom version of JML.

Jekyll multiple languages plugin describes how to import/use the plugin manually (or as a submodule):
https://github.com/kurtsson/jekyll-multiple-languages-plugin?tab=readme-ov-file#32-manually

I couldn't get it to work.. infinite recursion.. dependency still attempted to be grabbed from an external resource instead of locally. I am hoping its just my lack of ruby/gem/plugin knowledge and someone can help/advise.

@plowsof
Copy link
Collaborator Author

plowsof commented Jul 9, 2024

i seem to have got it working, just the .rb file in _plugins will auto load. combined with cleaning any mention of JML plugin from config files https://jekyllrb.com/docs/plugins/installation/

@plowsof plowsof changed the title Request/help: use our own custom Jekyll-Multiple-Languages-Plugin use our own custom Jekyll-Multiple-Languages-Plugin Jul 9, 2024
@plowsof
Copy link
Collaborator Author

plowsof commented Jul 9, 2024

ruby 3.2.4 now builds with a custom JML script. the "nil into string" error was fixed by adding some extra parsing logic. this was a speedrun just to make myself feel confident about getmonero having a none EOL ruby version in ~8 months. I need to put the changes into an acceptable/re-viewable PR.

plowsof#29

@plowsof plowsof linked a pull request Jul 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant