Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_includes/header.html: liquid whitespace control #2322

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

plowsof
Copy link
Collaborator

@plowsof plowsof commented Jul 16, 2024

we're putting whitespace into the raw html files due to not using any whitespace control in the liquid script which decides what locale to add to the homepage url.

This can effect plugins which parse/edit urls such as jekyll-loading-lazy which we dont actually need but its just bad practice and could effect other plugins in the future.

if we inspect the monero logo / homepage shortcut in the header at getmonero.org we see:
Screenshot from 2024-07-16 10-13-09

with this change:
Screenshot from 2024-07-16 10-29-01

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b7e56a5
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/66963f22dffd030008933105
😎 Deploy Preview https://deploy-preview-2322--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@plowsof plowsof merged commit 1694962 into monero-project:master Oct 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants