-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update userguide matrix via element #2364
Conversation
✅ Deploy Preview for barolo-time-757cf9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
its nice to see inline srcset however what are we doing here? future proofing -site for a time when jpgxl's are more widely supported when its going to be replaced shortly? if we had translations set up we would be presenting translators with alot of raw html. replacing the screenshots with new avifs is perfectly acceptable. I'd much rather see your efforts and knowledge put into how we should be displaying images in astro / discussing fallbacks/image types with the new designer/dev. |
yes, JPEG XL has more features and looks more freer format*, that's why I preferred over AVIF. In my testings: there's more detailed comparison: https://cloudinary.com/blog/time_for_next_gen_codecs_to_dethrone_jpeg |
f3c1a24
to
e7d9957
Compare
converting to ready for review, IOS screenshots can be fixed with different PR |
NACK - remove the srcset busy work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like someone to update the iPhone screenshots. I asked in monero-site matrix.
unfortunately, i dont have an ios device. Also, since element doesnt allow multiple accounts.. a user will have to logout from their matrix if they want to screenshot the setup.
Approving anyway.
22a9b5f
to
c550f83
Compare
Apparently iOS screenshots look the same as Android's so @HardenedSteel is suggesting we skip those and just use Android's. Related link. |
Updated outdated screenshots and added missing content. Co-authored-by: nahuhh <[email protected]>
IOS screenshots are missingIOS and Android GUIs are same so IOS screenshots are removed and not updated.will close #2361