Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update userguide matrix via element #2364

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

HardenedSteel
Copy link
Contributor

@HardenedSteel HardenedSteel commented Aug 30, 2024

IOS screenshots are missing IOS and Android GUIs are same so IOS screenshots are removed and not updated.

will close #2361

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3327e4f
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/6709e8bef4fef50008bd920b
😎 Deploy Preview https://deploy-preview-2364--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@plowsof
Copy link
Collaborator

plowsof commented Aug 30, 2024

its nice to see inline srcset however what are we doing here? future proofing -site for a time when jpgxl's are more widely supported when its going to be replaced shortly? if we had translations set up we would be presenting translators with alot of raw html. replacing the screenshots with new avifs is perfectly acceptable.

I'd much rather see your efforts and knowledge put into how we should be displaying images in astro / discussing fallbacks/image types with the new designer/dev.

@HardenedSteel
Copy link
Contributor Author

future proofing -site for a time when jpgxl's are more widely supported when its going to be replaced shortly?

yes, JPEG XL has more features and looks more freer format*, that's why I preferred over AVIF.

In my testings:
AVIF performing better for more lossy pictures
JPEG XL performing better for less (or lossless) pictures

there's more detailed comparison: https://cloudinary.com/blog/time_for_next_gen_codecs_to_dethrone_jpeg

@HardenedSteel HardenedSteel marked this pull request as ready for review September 10, 2024 01:46
@HardenedSteel
Copy link
Contributor Author

converting to ready for review, IOS screenshots can be fixed with different PR

@plowsof
Copy link
Collaborator

plowsof commented Sep 15, 2024

NACK - remove the srcset busy work.

Copy link
Contributor

@nahuhh nahuhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like someone to update the iPhone screenshots. I asked in monero-site matrix.

unfortunately, i dont have an ios device. Also, since element doesnt allow multiple accounts.. a user will have to logout from their matrix if they want to screenshot the setup.

Approving anyway.

_i18n/en/resources/user-guides/join-monero-matrix.md Outdated Show resolved Hide resolved
@HardenedSteel HardenedSteel force-pushed the matrix branch 4 times, most recently from 22a9b5f to c550f83 Compare October 11, 2024 02:30
@rottenwheel
Copy link
Contributor

Apparently iOS screenshots look the same as Android's so @HardenedSteel is suggesting we skip those and just use Android's.

Related link.

Updated outdated screenshots and added missing content.

Co-authored-by: nahuhh <[email protected]>
@plowsof plowsof merged commit 23c4983 into monero-project:master Oct 15, 2024
6 checks passed
@HardenedSteel HardenedSteel deleted the matrix branch October 15, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update join Monero core team Matrix server guide; screenshots outdated
4 participants