Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set anchors target for external urls to _blank #2379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HardenedSteel
Copy link
Contributor

@HardenedSteel HardenedSteel commented Oct 7, 2024

closes #1921, closes #2118, closes #2233

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 558f083
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/67033b95957afd0008625491
😎 Deploy Preview https://deploy-preview-2379--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@plowsof
Copy link
Collaborator

plowsof commented Oct 7, 2024

nack, duplicate of #2233 (or it required a rebase?) and lack of communication leading to you overlooking #2235 (a plugin that handles this for us)

@HardenedSteel
Copy link
Contributor Author

#2233 has merge conflicts, i don't know about the plugin, i missed that

@plowsof
Copy link
Collaborator

plowsof commented Oct 7, 2024

Asking for a rebase is common practice. I can rebase today. But i prefer the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links don't open in new tabs
3 participants