chore: drop node 16 and add node 22 to CI matrix MONGOSH-1898 #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Nov 8, 2024
addaleax
changed the title
Yeah, if we don't test it, it's probably best to bump it 👍 |
addaleax
reviewed
Nov 12, 2024
packages/e2e-tests/test/e2e.spec.ts
Outdated
| ) { | ||
| // This test fails on Windows with node 22 likely due to https://github.com/nodejs/node/issues/51766 | ||
| return this.skip(); | ||
| } |
There was a problem hiding this comment.
Hm, this might be something we want to track in our own JIRA? Not sure if we should consider this a blocker to adopting Node.js 22 for our official builds, but we should probably at least discuss it
There was a problem hiding this comment.
Agreed - was hoping to get this to a stable state and then I'll go back and compile a list of the hacks/questionable changes that we should double check on prior to merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
node >= 16.15.0- should we bump that as well?reads and runs the vscode extension example playgroundreads and runs code from stdin, with .end()cannot auth when authenticationMechanism mismatches (sha1 -> sha256)cannot auth when authenticationMechanism mismatches (sha256 -> sha1)