Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(EAI-566): Support creating new conversation when add message when conversationId = "null" #531

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

(EAI-566): Support creating new conversation when add message when conversationId = "null" #531

wants to merge 19 commits into from

Conversation

mongodben
Copy link
Collaborator

@mongodben mongodben commented Oct 4, 2024 •
edited
Loading

Jira: https://jira.mongodb.org/browse/EAI-566

Changes

  • Add logic to create new conversation from addMessageToConversation endpoint when conversationId = "null"
  • Document functionality
  • Update mongodb-chatbot-server test suite to use in-memory MongoDB. this reduces risk of us making a collection in dev/test clusters and not cleaning it up. could also affect speed of test suite in CI (hopefully for the better)

Notes

  • This functionality is added to our implementation by default as its the new default behavior

@mongodben mongodben requested a review from nlarew October 8, 2024 14:39
@mongodben mongodben added the DO NOT MERGE Not yet ready for merge label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlarew nlarew nlarew approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE Not yet ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mongodben @nlarew