-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-44208) Removes nested components from last page of Kafka docs #172
Conversation
✅ Deploy Preview for docs-kafka-connector ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a super minor curiosity question! Thanks!
for the same span of time you used for the preceding step. | ||
#. Divide the change in the value of the ``mongodb-bytes-read`` attribute | ||
by the change in the value of the ``records`` attribute. | ||
#. Determine the change in the value of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rendering fine as a numbered list so no changes needed, but curiosity question: For inline markup, should we be writing ordered numbered lists as:
#.
#.
Or will #. always render as numbers if it is not preceded by any other numerator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It defaults to numbers, but if you want the list to use a, b, c or i, ii, iii, you need to specify the first one. So it's best to specify what you want for the first one in most cases.
JIRA - https://jira.mongodb.org/browse/DOCSP-44208
STAGING - https://deploy-preview-172--docs-kafka-connector.netlify.app/monitoring/#example---monitor-the-quick-start