Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-44208) Removes nested components from last page of Kafka docs #172

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

sarahsimpers
Copy link
Collaborator

@sarahsimpers sarahsimpers commented Oct 8, 2024

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for docs-kafka-connector ready!

Name Link
🔨 Latest commit 57e85fa
🔍 Latest deploy log https://app.netlify.com/sites/docs-kafka-connector/deploys/6705406bdcb308000859e313
😎 Deploy Preview https://deploy-preview-172--docs-kafka-connector.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@elyse-mdb elyse-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a super minor curiosity question! Thanks!

for the same span of time you used for the preceding step.
#. Divide the change in the value of the ``mongodb-bytes-read`` attribute
by the change in the value of the ``records`` attribute.
#. Determine the change in the value of the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rendering fine as a numbered list so no changes needed, but curiosity question: For inline markup, should we be writing ordered numbered lists as:

#.
#.

Or will #. always render as numbers if it is not preceded by any other numerator?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It defaults to numbers, but if you want the list to use a, b, c or i, ii, iii, you need to specify the first one. So it's best to specify what you want for the first one in most cases.

@sarahsimpers sarahsimpers merged commit 0e01dbd into mongodb:master Oct 8, 2024
4 of 6 checks passed
sarahsimpers added a commit to sarahsimpers/docs-kafka-connector-mdb that referenced this pull request Oct 8, 2024
sarahsimpers added a commit to sarahsimpers/docs-kafka-connector-mdb that referenced this pull request Oct 8, 2024
sarahsimpers added a commit to sarahsimpers/docs-kafka-connector-mdb that referenced this pull request Oct 8, 2024
sarahsimpers added a commit to sarahsimpers/docs-kafka-connector-mdb that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants