CLOUDP-279538 Unify http transport #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeroenvervaeke
previously approved these changes
Nov 20, 2024
gssbzn
reviewed
Nov 20, 2024
internal/transport/transport.go
Outdated
Comment on lines
36
to
42
| func Default() *http.Transport { | ||
| return newTransport(timeout) | ||
| } | ||
|
|
||
| func Telemetry() *http.Transport { | ||
| return newTransport(telemetryTimeout) | ||
| } |
There was a problem hiding this comment.
could these be singleton? the difference right now with this approach is that there use to be a single instance of transport while now you'll create multiple ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Unify http transport
Jira ticket: CLOUDP-279538
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments