Replace JSON.parse with parseJsonWithSchema

[fehmer]

Replace JSON.parse with Misc.parseJsonWithSchema for type safety.

Example:

monkeytype/frontend/src/ts/utils/url-handler.ts

Lines 68 to 92 in 2a0a5b4

	const customThemeUrlDataSchema = z.object({
	c: CustomThemeColorsSchema,
	i: z.string().optional(),
	s: CustomBackgroundSizeSchema.optional(),
	f: CustomBackgroundFilterSchema.optional(),
	});
	export function loadCustomThemeFromUrl(getOverride?: string): void {
	const getValue = Misc.findGetParameter("customTheme", getOverride);
	if (getValue === null) return;
	let decoded: z.infer<typeof customThemeUrlDataSchema>;
	try {
	decoded = Misc.parseJsonWithSchema(
	atob(getValue),
	customThemeUrlDataSchema
	);
	} catch (e) {
	console.log("Custom theme URL decoding failed", e);
	Notifications.add(
	"Failed to load theme from URL: " + (e as Error).message,
	0
	);
	return;
	}

[Miodec]

I think before we do this we should extract common util functions (like this one) to a package.

[rajneesh-18]

It should be go on the discussion.

[dev-mohit06]

Hi @fehmer, Could you assign me that issue.

[fehmer]

@dev-mohit06 I'd say just work on it and create a PR

[dev-mohit06]

Hey @fehmer, I’d prefer to avoid duplication of effort, so could you assign this issue to me if possible?

[dev-mohit06]

@fehmer - Could you please indicate which files in the frontend need JSON.parse replacements? This will help ensure I cover all necessary changes.

[fehmer]

https://github.com/search?q=repo%3Amonkeytypegame%2Fmonkeytype+JSON.parse+language%3ATypeScript+path%3A%2F%5Efrontend%5C%2Fsrc%5C%2Fts%5C%2F%2F&type=code

[dev-mohit06]

@fehmer thanks for helping me out