Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impr(quotes): Add English quotes (@TheFrenchTechMan) #6039

Merged
merged 13 commits into from
Dec 4, 2024
Merged

impr(quotes): Add English quotes (@TheFrenchTechMan) #6039

merged 13 commits into from
Dec 4, 2024

Conversation

TheFrenchTechMan
Copy link
Contributor

@TheFrenchTechMan TheFrenchTechMan commented Nov 15, 2024 •
edited
Loading

Description

Added some quotes to the English file.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@Miodec
Copy link
Member

Miodec commented Nov 15, 2024

Please remove the last one.

@TheFrenchTechMan
Copy link
Contributor Author

Is it because of the wrong ID or for something else?

@Miodec
Copy link
Member

Miodec commented Nov 15, 2024

I don't really like its content, IDs seem fine.

@TheFrenchTechMan
Copy link
Contributor Author

It should be removed...?

@TheFrenchTechMan
Copy link
Contributor Author

I think it can be merged now.

Miodec
Miodec previously approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions GitHub Actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 18, 2024
@TheFrenchTechMan
Copy link
Contributor Author

The checks failed because in one of the quotes there are quotation marks, and backslashes to include them correctly, but they are being counted by the auto checker thing.

@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 20, 2024
@Miodec
Copy link
Member

Miodec commented Nov 21, 2024

The checks failed because in one of the quotes there are quotation marks, and backslashes to include them correctly, but they are being counted by the auto checker thing.

Then you need to update the length property to what the continous integration script is saying it should be.

@github-actions GitHub Actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 21, 2024
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 21, 2024
@TheFrenchTechMan
Copy link
Contributor Author

Ok, now it should be good.

@github-actions GitHub Actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@TheFrenchTechMan
Copy link
Contributor Author

I'm going insane

@TheFrenchTechMan
Copy link
Contributor Author

You can review the changes now

@TheFrenchTechMan
Copy link
Contributor Author

@Miodec?

Miodec
Miodec approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit 4c4e823 into monkeytypegame:master Dec 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Miodec approved these changes

Assignees
No one assigned
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheFrenchTechMan @Miodec @monkeytypegeorge