Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Extract router module from react/base, and use plop to generate it #1264

Open
Tracked by #1268
ptrkdan opened this issue Jun 7, 2024 · 0 comments
Open
Tracked by #1268
Assignees
Labels
CLI enhancement New feature or request
Milestone

Comments

@ptrkdan
Copy link
Collaborator

ptrkdan commented Jun 7, 2024

Is your feature request related to a problem? Please describe.

wouter is currently included in react/base. It is possible that users may not want a router solution for their project, so the current implementation would only bloat the generated project.

Additionally, since we are currently revising the generation script to use plop, it would be a good opportunity to try implementing this via plop.

Describe the solution you'd like

  1. Extract router related code from react/base as its own module
  2. Add "Add router" in the module selection of the CLI script.
  3. Add additional CLI prompt to select which router solution to use, if the user selects the "Add router" selection.
    a. Add both wouter and react-router selection
  4. Add handlebar templates for wouter and react-router modules.
  5. Add plop generator for the router module.

Additional context (optional)

Add any other context or screenshots about the feature request here.

@ptrkdan ptrkdan added enhancement New feature or request CLI labels Jun 7, 2024
@ptrkdan ptrkdan self-assigned this Jun 7, 2024
@ptrkdan ptrkdan moved this to In Progress in ml-frontend Jun 7, 2024
@jinmayamashita jinmayamashita added this to the 2024-Q2 milestone Jun 13, 2024
@ptrkdan ptrkdan mentioned this issue Jun 14, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants