Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Flexible base directory configuration in React boilerplate #854

Open
2 tasks
jinmayamashita opened this issue Jul 21, 2023 · 0 comments
Open
2 tasks
Assignees
Labels
enhancement New feature or request

Comments

@jinmayamashita
Copy link
Collaborator

jinmayamashita commented Jul 21, 2023

Description

When building the React boilerplate app using Vite, it assumes the baseUrl to be the root directory, making it challenging to have a flexible base dir configuration (e.g., for GitHub Pages with https://<USERNAME>.github.io/<REPO>/). I want to make it adaptable to any directory.

Context

When attempting to build and deploy to GitHub Pages, I encountered an issue where the base URL was set to https://<USERNAME>.github.io/<REPO>/, resulting in the failure to render the application on the page. 😢

Possible Implementation

  • Adjust the base of the vite setting.1
  • Allow baseUrl to be specified as an environment variable

Footnotes

  1. https://vitejs.dev/guide/static-deploy.html#github-pages

@jinmayamashita jinmayamashita self-assigned this Jul 21, 2023
@ptrkdan ptrkdan added the enhancement New feature or request label Dec 19, 2023
@ptrkdan ptrkdan changed the title Flexible base directory configuration in React boilerplate [FEATURE] Flexible base directory configuration in React boilerplate Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants