Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending pull request #15

Closed
rschrenk opened this issue Jun 16, 2021 · 4 comments
Closed

Pending pull request #15

rschrenk opened this issue Jun 16, 2021 · 4 comments

Comments

@rschrenk
Copy link

Dear Alexander,

we had contact regarding the merger of my plugins availability_globalrole and availability_coursecatrole into availability_role. I made all required changes and set up a pull request, but it has not been accepted.

In the meanwhile it seems you have been working on the plugin, so my functionality is lost when updating.

Could you please integrate my changes?
#11

Best wishes
Robert

@abias
Copy link
Member

abias commented Jun 23, 2021

Hi @rschrenk ,

I am sorry that I did not have the time to review your PR and finally merge it last year. We went through a hard phase last year where we had to pause our Moodle development and only did the most necessary things like upgrading the plugins to Moodle 3.10.

I can assure you that your PR #11 is not lost and still open and it still can be merged into the plugin.

This plugin will also soon get an additional maintainer and we will see when we can work through your useful addition in #11.

Cheers,
Alex

@abias abias closed this as completed Jun 23, 2021
@rschrenk
Copy link
Author

Hi @abias

we will do our Moodle updates in mid July. Is there a chance to get this PR done till then?

Regards
Robert

@rschrenk
Copy link
Author

Hi @abias

Is there chance, that you pull my changes into the plugin now? You also developed new features, so I don't think I should work on my fork, but my changes may be of interest for all users of this plugin.

Best regards
Robert

@PM84
Copy link

PM84 commented May 31, 2023

I would also like to express my support for this feature. If I can help, please feel free to let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants