Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course format Topics Additions #467

Open
mwehr opened this issue Nov 9, 2023 · 3 comments · May be fixed by #457
Open

Course format Topics Additions #467

mwehr opened this issue Nov 9, 2023 · 3 comments · May be fixed by #457
Assignees
Labels
discussion needed Something which needs to be discussed before writing the first line of code feature Something which is a new feature or big improvement

Comments

@mwehr
Copy link
Collaborator

mwehr commented Nov 9, 2023

Course format Topics Additions.

The following extension would be nice for the Topics course format.

Display of the section summary in collapsed state.
always_show_summary_1always_show_summary_2

Permanent display of all contents of the initial section so that the section can be used as a course header.
always_show_header

Both features activated together.
both

The two features should be globally configurable in the admin section for all courses using the Topics course format and, if required, each course should be allowed to overwrite the global default.
admin_settingssettings_course_instance

@mwehr mwehr added the new Something which has been reported but has not yet beeen triaged by the team label Nov 9, 2023
@mwehr mwehr linked a pull request Nov 9, 2023 that will close this issue
@lucaboesch
Copy link
Collaborator

Dear @mwehr please confirm (and prove in screenshots if you want to be perfect) that this is also working in the "Show one section per page" course layout option. It would be optimal, of course, if it would work in the "Weekly format" as well.

If it would, that would finally eliminate the last need for the "Collapsed topics" course format in my institution (I've made it so that the course formats do look the same visually but some lecturers are keen to wanting to show the contents of the initial section all over the place. Your "Always show initial section".).

@whuml whuml added feature Something which is a new feature or big improvement and removed new Something which has been reported but has not yet beeen triaged by the team labels Nov 16, 2023
@mwehr
Copy link
Collaborator Author

mwehr commented Nov 16, 2023

Hi @lucaboesch,

Originally, I only had the Topics format in mind. I took a look at the weekly format and since it works the same way, it should be no problem to provide the two features for this format as well.

I am currently reworking the two features towards a more maintainable integration.

Basically, both features can be integrated without changing the templates.

A first version should be available in the next days.

The question is whether there should be two separate configurations, i.e. 2 course custom fields for Topics and 2 for Weekly or is one enough?

What do you think ?

@wiebkemueller-hsh wiebkemueller-hsh added the discussion needed Something which needs to be discussed before writing the first line of code label Nov 23, 2023
@mwehr
Copy link
Collaborator Author

mwehr commented Nov 26, 2023

Hi @lucaboesch,

I've added a reworked version.
Basically what changed:

  • No need to override templates. Moved logic to JS
  • Added support for Weekly Format.
  • Added support for hiding the title in the initial section when in "always show" mode.

weekly

Should be ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needed Something which needs to be discussed before writing the first line of code feature Something which is a new feature or big improvement
Projects
Status: To do REQ
Development

Successfully merging a pull request may close this issue.

4 participants